docs: README refresh + integrator notes for corporate-action auto-pause (RAI-325)#26
Open
hardyjosh wants to merge 1 commit into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced May 9, 2026
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 9, 2026
hardyjosh
force-pushed
the
docs/readme-integrator-notes
branch
from
3a4993a to
ff44dc8
Compare
hardyjosh
force-pushed
the
feat/deployer-corporate-action-config
branch
from
8b5cd92 to
652a1f2
Compare
hardyjosh
force-pushed
the
docs/readme-integrator-notes
branch
from
ff44dc8 to
4d07787
Compare
hardyjosh
force-pushed
the
feat/deployer-corporate-action-config
branch
from
652a1f2 to
1b96000
Compare
hardyjosh
force-pushed
the
docs/readme-integrator-notes
branch
from
4d07787 to
f45f652
Compare
hardyjosh
force-pushed
the
feat/deployer-corporate-action-config
branch
from
1b96000 to
5362638
Compare
This was referenced May 11, 2026
Closed
Closed
hardyjosh
pushed a commit
that referenced
this pull request
May 11, 2026
Two unrelated CI fixes for the audit stack, bundled because both are blocking every downstream PR's CI. 1. **subgraph/subgraph.yaml event signatures** — the corp-actions stack (PRs #20–#26) added a `CorporateActionPauseConfig` struct field to `PythOracleAdapterInitialized` and `MultiPythOracleAdapterInitialized` event payloads but didn't update the subgraph. As a result the `test` job (graph codegen) fails across every PR in the stack — "Event with signature ... not present in ABI". Subgraph handlers don't reference the new `pauseConfig` tuple, so only the YAML signature lines change. 2. **`vm.expectRevert(abi.encodeWithSelector(ZeroArgError.selector))` → `vm.expectRevert(ZeroArgError.selector)`** — foundry-nightly 1.6 has an ABI-decoder panic in alloy-dyn-abi-1.5.2 (`range end index 4 out of range for slice of length 0`) when running `expectRevert` against a zero-arg custom error encoded via `abi.encodeWithSelector(...)` with no args. The `bytes4` overload bypasses the buggy decode path. Bulk-sed'd across all test files (~92 sites in 20 files). Behaviour unchanged — both forms expect the same 4-byte selector. Closes the `rainix-sol-test` and `test` CI failures across the stack. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
hardyjosh
pushed a commit
that referenced
this pull request
May 11, 2026
Two unrelated CI fixes for the audit stack, bundled because both are blocking every downstream PR's CI. 1. **subgraph/subgraph.yaml event signatures** — the corp-actions stack (PRs #20–#26) added a `CorporateActionPauseConfig` struct field to `PythOracleAdapterInitialized` and `MultiPythOracleAdapterInitialized` event payloads but didn't update the subgraph. As a result the `test` job (graph codegen) fails across every PR in the stack — "Event with signature ... not present in ABI". Subgraph handlers don't reference the new `pauseConfig` tuple, so only the YAML signature lines change. 2. **`vm.expectRevert(abi.encodeWithSelector(ZeroArgError.selector))` → `vm.expectRevert(ZeroArgError.selector)`** — foundry-nightly 1.6 has an ABI-decoder panic in alloy-dyn-abi-1.5.2 (`range end index 4 out of range for slice of length 0`) when running `expectRevert` against a zero-arg custom error encoded via `abi.encodeWithSelector(...)` with no args. The `bytes4` overload bypasses the buggy decode path. Bulk-sed'd across all test files (~92 sites in 20 files). Behaviour unchanged — both forms expect the same 4-byte selector. Closes the `rainix-sol-test` and `test` CI failures across the stack. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
hardyjosh
pushed a commit
that referenced
this pull request
May 11, 2026
Two unrelated CI fixes for the audit stack, bundled because both are blocking every downstream PR's CI. 1. **subgraph/subgraph.yaml event signatures** — the corp-actions stack (PRs #20–#26) added a `CorporateActionPauseConfig` struct field to `PythOracleAdapterInitialized` and `MultiPythOracleAdapterInitialized` event payloads but didn't update the subgraph. As a result the `test` job (graph codegen) fails across every PR in the stack — "Event with signature ... not present in ABI". Subgraph handlers don't reference the new `pauseConfig` tuple, so only the YAML signature lines change. 2. **`vm.expectRevert(abi.encodeWithSelector(ZeroArgError.selector))` → `vm.expectRevert(ZeroArgError.selector)`** — foundry-nightly 1.6 has an ABI-decoder panic in alloy-dyn-abi-1.5.2 (`range end index 4 out of range for slice of length 0`) when running `expectRevert` against a zero-arg custom error encoded via `abi.encodeWithSelector(...)` with no args. The `bytes4` overload bypasses the buggy decode path. Bulk-sed'd across all test files (~92 sites in 20 files). Behaviour unchanged — both forms expect the same 4-byte selector. Closes the `rainix-sol-test` and `test` CI failures across the stack. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
hardyjosh
pushed a commit
that referenced
this pull request
May 11, 2026
Two unrelated CI fixes for the audit stack, bundled because both are blocking every downstream PR's CI. 1. **subgraph/subgraph.yaml event signatures** — the corp-actions stack (PRs #20–#26) added a `CorporateActionPauseConfig` struct field to `PythOracleAdapterInitialized` and `MultiPythOracleAdapterInitialized` event payloads but didn't update the subgraph. As a result the `test` job (graph codegen) fails across every PR in the stack — "Event with signature ... not present in ABI". Subgraph handlers don't reference the new `pauseConfig` tuple, so only the YAML signature lines change. 2. **`vm.expectRevert(abi.encodeWithSelector(ZeroArgError.selector))` → `vm.expectRevert(ZeroArgError.selector)`** — foundry-nightly 1.6 has an ABI-decoder panic in alloy-dyn-abi-1.5.2 (`range end index 4 out of range for slice of length 0`) when running `expectRevert` against a zero-arg custom error encoded via `abi.encodeWithSelector(...)` with no args. The `bytes4` overload bypasses the buggy decode path. Bulk-sed'd across all test files (~92 sites in 20 files). Behaviour unchanged — both forms expect the same 4-byte selector. Closes the `rainix-sol-test` and `test` CI failures across the stack. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
hardyjosh
pushed a commit
that referenced
this pull request
May 11, 2026
Two unrelated CI fixes for the audit stack, bundled because both are blocking every downstream PR's CI. 1. **subgraph/subgraph.yaml event signatures** — the corp-actions stack (PRs #20–#26) added a `CorporateActionPauseConfig` struct field to `PythOracleAdapterInitialized` and `MultiPythOracleAdapterInitialized` event payloads but didn't update the subgraph. As a result the `test` job (graph codegen) fails across every PR in the stack — "Event with signature ... not present in ABI". Subgraph handlers don't reference the new `pauseConfig` tuple, so only the YAML signature lines change. 2. **`vm.expectRevert(abi.encodeWithSelector(ZeroArgError.selector))` → `vm.expectRevert(ZeroArgError.selector)`** — foundry-nightly 1.6 has an ABI-decoder panic in alloy-dyn-abi-1.5.2 (`range end index 4 out of range for slice of length 0`) when running `expectRevert` against a zero-arg custom error encoded via `abi.encodeWithSelector(...)` with no args. The `bytes4` overload bypasses the buggy decode path. Bulk-sed'd across all test files (~92 sites in 20 files). Behaviour unchanged — both forms expect the same 4-byte selector. Closes the `rainix-sol-test` and `test` CI failures across the stack. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
hardyjosh
force-pushed
the
feat/deployer-corporate-action-config
branch
from
5362638 to
de63173
Compare
hardyjosh
force-pushed
the
docs/readme-integrator-notes
branch
2 times, most recently
from
84e2f79 to
b0f9ab3
Compare
hardyjosh
force-pushed
the
feat/deployer-corporate-action-config
branch
from
7d66e15 to
14c6010
Compare
hardyjosh
force-pushed
the
docs/readme-integrator-notes
branch
2 times, most recently
from
34be518 to
cfbe962
Compare
hardyjosh
force-pushed
the
feat/deployer-corporate-action-config
branch
from
14c6010 to
d5df7d5
Compare
hardyjosh
force-pushed
the
docs/readme-integrator-notes
branch
from
cfbe962 to
ad2d7a9
Compare
hardyjosh
force-pushed
the
feat/deployer-corporate-action-config
branch
from
d5df7d5 to
5b2a6b3
Compare
This was referenced May 26, 2026
hardyjosh
force-pushed
the
feat/deployer-corporate-action-config
branch
from
5b2a6b3 to
93eb80d
Compare
hardyjosh
force-pushed
the
docs/readme-integrator-notes
branch
from
ad2d7a9 to
6fdcad4
Compare
…se (RAI-325) README updates: * Mention auto-pause behaviour and the MultiPythOracleAdapter alongside PythOracleAdapter in the architecture overview * Updated repository structure to reflect src/abstract, MultiPythOracleAdapter / MultiOracleUnifiedDeployer, and LibCorporateActionsPause * New § Integrator notes: corporate actions covering: distinct revert selectors (OraclePausedManual vs OraclePausedCorporateAction(uint64)), what happens to lending-market positions during the window, the 'consume convertToAssets if you can't tolerate revert' fallback for integrators that can't stomach a reverting oracle.
hardyjosh
force-pushed
the
docs/readme-integrator-notes
branch
from
6fdcad4 to
c57e684
Compare
hardyjosh
force-pushed
the
feat/deployer-corporate-action-config
branch
from
93eb80d to
413917f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
README updates: