Skip to content

docs(spec): corporate-action-aware auto-pause semantics (RAI-318)#21

Open
hardyjosh wants to merge 1 commit into
deps/migrate-to-soldeerfrom
docs/spec-corporate-action-pause
Open

docs(spec): corporate-action-aware auto-pause semantics (RAI-318)#21
hardyjosh wants to merge 1 commit into
deps/migrate-to-soldeerfrom
docs/spec-corporate-action-pause

Conversation

@hardyjosh

Copy link
Copy Markdown
Collaborator

Adds § 16 Corporate-Action-Aware Auto-Pause to SPEC.md ahead of the implementation work in RAI-319 / RAI-320 / RAI-321. Covers: configuration struct (corporateActionsVault, actionTypeMask, pauseTimeBefore, pauseTimeAfter — all immutable post-init); pause window definition driven by ICorporateActionsV1.earliestActionOfType(PENDING) and latestActionOfType(COMPLETED); independence from manual setPaused; behaviour with multiple pending actions, partial migration, cancelled actions; action-type forward compatibility via bitmap mask; replacement of OraclePaused with disambiguated OraclePausedManual + OraclePausedCorporateAction(uint64) errors.

Renumbers References from § 16 to § 17.

Updates § 14 migration table to drop the manual pause/unpause row and add the redeploy + registry-switch pattern for retuning the pause window.

Updates § 15 corporate-actions security note to reflect the auto-pause design.

@linear

linear Bot commented May 9, 2026

Copy link
Copy Markdown

RAI-318

@coderabbitai

coderabbitai Bot commented May 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 879b124a-71f8-4ab5-8fe0-abe271fda19d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/spec-corporate-action-pause

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

hardyjosh commented May 9, 2026

Copy link
Copy Markdown
Collaborator Author

@hardyjosh hardyjosh force-pushed the chore/bump-st0x-deploy-submodule branch from 5897e29 to c8c1b7d Compare May 9, 2026 11:51
@hardyjosh hardyjosh force-pushed the docs/spec-corporate-action-pause branch from 0540e39 to 581a552 Compare May 9, 2026 11:51
@hardyjosh hardyjosh changed the base branch from chore/bump-st0x-deploy-submodule to graphite-base/21 May 26, 2026 17:34
@hardyjosh hardyjosh force-pushed the docs/spec-corporate-action-pause branch from 581a552 to 6af8c8f Compare May 26, 2026 17:35
@hardyjosh hardyjosh changed the base branch from graphite-base/21 to deps/migrate-to-soldeer May 26, 2026 17:35
Adds § 16 Corporate-Action-Aware Auto-Pause to SPEC.md ahead of the implementation work in RAI-319 / RAI-320 / RAI-321. Covers: configuration struct (corporateActionsVault, actionTypeMask, pauseTimeBefore, pauseTimeAfter — all immutable post-init); pause window definition driven by ICorporateActionsV1.earliestActionOfType(PENDING) and latestActionOfType(COMPLETED); independence from manual setPaused; behaviour with multiple pending actions, partial migration, cancelled actions; action-type forward compatibility via bitmap mask; replacement of OraclePaused with disambiguated OraclePausedManual + OraclePausedCorporateAction(uint64) errors.

Renumbers References from § 16 to § 17.

Updates § 14 migration table to drop the manual pause/unpause row and add the redeploy + registry-switch pattern for retuning the pause window.

Updates § 15 corporate-actions security note to reflect the auto-pause design.
@hardyjosh hardyjosh force-pushed the docs/spec-corporate-action-pause branch from 6af8c8f to e9cc087 Compare May 31, 2026 11:48
@hardyjosh hardyjosh force-pushed the deps/migrate-to-soldeer branch from 41d50b3 to 70bd2dd Compare May 31, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant