test(audit-low): coverage sweep 2 — 15 LOW test findings in one pass#232
test(audit-low): coverage sweep 2 — 15 LOW test findings in one pass#232hardyjosh wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3fecffb to
6154ea4
Compare
90b10ce to
48e95fd
Compare
6154ea4 to
1315d9c
Compare
48e95fd to
1fa5fb4
Compare
1315d9c to
e404e74
Compare
1fa5fb4 to
8619624
Compare
e404e74 to
a0ad72a
Compare
8619624 to
71f2411
Compare
71f2411 to
dae71e5
Compare
a0ad72a to
5678933
Compare
- #51: testDescription for single-feed + multi-feed Pyth adapter initializes. - #56 #58 #59: BadImpl reverter + InitFailure tests on Registry/Passthrough/Pyth BeaconSetDeployer construct tests (mirrors the existing Morpho/MultiPyth pattern). The Deployment-event emission is already covered by testDeploymentEventIsIndexed in each file. - #57: testOracleUnifiedDeployerPropagatesNonEmptyPauseConfig fuzz. - #61: testInitializeSignatureOverloadAlwaysReverts x5 contracts. - #62: testCannotDoubleInitialize x5 contracts. - #64 #65: NonPositivePrice / ZeroVaultSharePrice / publishTime parity on single-feed Pyth adapter via mock to avoid fork RPC env — new PythOracleAdapter.latestAnswerMock.t.sol (non-fork) sibling. - #67: testSetRegistryUpdatesPriceResolution on Morpho + Passthrough. - #69: OracleRegistry tests use emit OracleRegistry.OracleSet/AdminSet in place of duplicate local event redeclarations. - #70: testSetOracleBulkEmptyArrays. - #76: testGetFeedsConsistencyWithGetFeed. - #74: testRevertingVaultPropagates + testEoaVaultPropagatesNoCodeBehaviour (via InPauseWindowCaller wrapper so vm.expectRevert hooks the right depth on an internal-library function). - #77: ProdFork bare vm.expectRevert() sites (12 total) all selector-specific; L468/L471 use vm.expectRevert(bytes("")) for the abi-decode-failure case. No source-code changes. Test count delta: 151 -> 169 (+18). nix CI green: forge fmt, forge fmt --check, rainix-sol-static (0 results), rainix-sol-legal (compliant), forge test --no-match-contract <fork suites>. Closes #51, #56, #57, #58, #59, #61, #62, #64, #65, #67, #69, #70, #74, #76, #77. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
5678933 to
a57f73a
Compare
dae71e5 to
5bdbd3f
Compare
|
Deferred for Euler launch. Test additions for already-working code; not Euler-blocking. |

Registry/Passthrough/Pyth BeaconSetDeployer construct tests
(mirrors the existing Morpho/MultiPyth pattern). The Deployment-event
emission is already covered by testDeploymentEventIsIndexed in each file.
on single-feed Pyth adapter via mock to avoid fork RPC env — new
PythOracleAdapter.latestAnswerMock.t.sol (non-fork) sibling.
in place of duplicate local event redeclarations.
(via InPauseWindowCaller wrapper so vm.expectRevert hooks the right depth
on an internal-library function).
L468/L471 use vm.expectRevert(bytes("")) for the abi-decode-failure case.
No source-code changes. Test count delta: 151 -> 169 (+18). nix CI green:
forge fmt, forge fmt --check, rainix-sol-static (0 results), rainix-sol-legal
(compliant), forge test --no-match-contract .
Closes #51, #56, #57, #58, #59, #61, #62, #64, #65, #67, #69, #70, #74, #76, #77.
Co-Authored-By: Claude Opus 4.7 noreply@anthropic.com