Skip to content

test(audit-low): coverage sweep 2 — 15 LOW test findings in one pass#232

Closed
hardyjosh wants to merge 1 commit into
fix/audit-low-style-refactorfrom
test/audit-low-coverage-sweep-2
Closed

test(audit-low): coverage sweep 2 — 15 LOW test findings in one pass#232
hardyjosh wants to merge 1 commit into
fix/audit-low-style-refactorfrom
test/audit-low-coverage-sweep-2

Conversation

@hardyjosh

Copy link
Copy Markdown
Collaborator

No source-code changes. Test count delta: 151 -> 169 (+18). nix CI green:
forge fmt, forge fmt --check, rainix-sol-static (0 results), rainix-sol-legal
(compliant), forge test --no-match-contract .

Closes #51, #56, #57, #58, #59, #61, #62, #64, #65, #67, #69, #70, #74, #76, #77.

Co-Authored-By: Claude Opus 4.7 noreply@anthropic.com

@coderabbitai

coderabbitai Bot commented May 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 72f91f23-605d-4589-8180-18afd200adc3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/audit-low-coverage-sweep-2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

hardyjosh commented May 11, 2026

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hardyjosh hardyjosh force-pushed the fix/audit-low-style-refactor branch from 3fecffb to 6154ea4 Compare May 11, 2026 16:15
@hardyjosh hardyjosh force-pushed the test/audit-low-coverage-sweep-2 branch from 90b10ce to 48e95fd Compare May 11, 2026 16:15
@hardyjosh hardyjosh force-pushed the fix/audit-low-style-refactor branch from 6154ea4 to 1315d9c Compare May 11, 2026 20:42
@hardyjosh hardyjosh force-pushed the test/audit-low-coverage-sweep-2 branch from 48e95fd to 1fa5fb4 Compare May 11, 2026 20:42
@hardyjosh hardyjosh force-pushed the fix/audit-low-style-refactor branch from 1315d9c to e404e74 Compare May 11, 2026 21:22
@hardyjosh hardyjosh force-pushed the test/audit-low-coverage-sweep-2 branch from 1fa5fb4 to 8619624 Compare May 11, 2026 21:22
@hardyjosh hardyjosh force-pushed the fix/audit-low-style-refactor branch from e404e74 to a0ad72a Compare May 11, 2026 21:52
@hardyjosh hardyjosh force-pushed the test/audit-low-coverage-sweep-2 branch from 8619624 to 71f2411 Compare May 11, 2026 21:52
@hardyjosh hardyjosh force-pushed the test/audit-low-coverage-sweep-2 branch from 71f2411 to dae71e5 Compare May 11, 2026 22:09
@hardyjosh hardyjosh force-pushed the fix/audit-low-style-refactor branch from a0ad72a to 5678933 Compare May 11, 2026 22:10
- #51:  testDescription for single-feed + multi-feed Pyth adapter initializes.
- #56 #58 #59: BadImpl reverter + InitFailure tests on
  Registry/Passthrough/Pyth BeaconSetDeployer construct tests
  (mirrors the existing Morpho/MultiPyth pattern). The Deployment-event
  emission is already covered by testDeploymentEventIsIndexed in each file.
- #57:  testOracleUnifiedDeployerPropagatesNonEmptyPauseConfig fuzz.
- #61:  testInitializeSignatureOverloadAlwaysReverts x5 contracts.
- #62:  testCannotDoubleInitialize x5 contracts.
- #64 #65: NonPositivePrice / ZeroVaultSharePrice / publishTime parity
  on single-feed Pyth adapter via mock to avoid fork RPC env — new
  PythOracleAdapter.latestAnswerMock.t.sol (non-fork) sibling.
- #67:  testSetRegistryUpdatesPriceResolution on Morpho + Passthrough.
- #69:  OracleRegistry tests use emit OracleRegistry.OracleSet/AdminSet
  in place of duplicate local event redeclarations.
- #70:  testSetOracleBulkEmptyArrays.
- #76:  testGetFeedsConsistencyWithGetFeed.
- #74:  testRevertingVaultPropagates + testEoaVaultPropagatesNoCodeBehaviour
  (via InPauseWindowCaller wrapper so vm.expectRevert hooks the right depth
  on an internal-library function).
- #77:  ProdFork bare vm.expectRevert() sites (12 total) all selector-specific;
  L468/L471 use vm.expectRevert(bytes("")) for the abi-decode-failure case.

No source-code changes. Test count delta: 151 -> 169 (+18). nix CI green:
forge fmt, forge fmt --check, rainix-sol-static (0 results), rainix-sol-legal
(compliant), forge test --no-match-contract <fork suites>.

Closes #51, #56, #57, #58, #59, #61, #62, #64, #65, #67, #69, #70, #74, #76, #77.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@hardyjosh hardyjosh force-pushed the fix/audit-low-style-refactor branch from 5678933 to a57f73a Compare May 11, 2026 22:27
@hardyjosh hardyjosh force-pushed the test/audit-low-coverage-sweep-2 branch from dae71e5 to 5bdbd3f Compare May 11, 2026 22:27
@hardyjosh

Copy link
Copy Markdown
Collaborator Author

Deferred for Euler launch. Test additions for already-working code; not Euler-blocking.

@hardyjosh hardyjosh closed this May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant