chore: bump st0x.deploy submodule for ICorporateActionsV1#20
Closed
hardyjosh wants to merge 1 commit into
Closed
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughUpdates the st0x.deploy submodule to a new commit and adds a foundry.toml remapping entry to wire the dependency into the build configuration system. Changesst0x.deploy Integration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
Author
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@foundry.toml`:
- Line 20: The st0x.deploy submodule (referenced as
"st0x.deploy/=lib/st0x.deploy/" in the manifest) is checked out at the wrong
commit (5897e291217dd89e47bd1618c4e811c253ac4fa2); update the submodule to the
expected commit 9955248669714aa37aaaa8fff994d763f6c12e89 by running git
submodule update --init --recursive (or cd into lib/st0x.deploy and
fetch/checkout the commit manually), then commit the updated submodule reference
so the repository points to the correct commit.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: ece36339-b079-44fc-8a3a-2027b4facb5f
📒 Files selected for processing (2)
foundry.tomllib/st0x.deploy
This was referenced May 9, 2026
Bumps lib/st0x.deploy from 766b468 to 9955248 (origin/main) and adds the st0x.deploy/= remapping. The newer ref exposes ICorporateActionsV1 — the interface the corporate-action-aware oracle work (RAI-318..328) consumes — along with its supporting libs and the cancelled-node sentinel semantics those rely on. No functional changes to oracle code in this commit; later PRs in the stack import from the new remapping.
hardyjosh
force-pushed
the
chore/bump-st0x-deploy-submodule
branch
from
5897e29 to
c8c1b7d
Compare
This was referenced May 11, 2026
Closed
Closed
hardyjosh
pushed a commit
that referenced
this pull request
May 11, 2026
Two unrelated CI fixes for the audit stack, bundled because both are blocking every downstream PR's CI. 1. **subgraph/subgraph.yaml event signatures** — the corp-actions stack (PRs #20–#26) added a `CorporateActionPauseConfig` struct field to `PythOracleAdapterInitialized` and `MultiPythOracleAdapterInitialized` event payloads but didn't update the subgraph. As a result the `test` job (graph codegen) fails across every PR in the stack — "Event with signature ... not present in ABI". Subgraph handlers don't reference the new `pauseConfig` tuple, so only the YAML signature lines change. 2. **`vm.expectRevert(abi.encodeWithSelector(ZeroArgError.selector))` → `vm.expectRevert(ZeroArgError.selector)`** — foundry-nightly 1.6 has an ABI-decoder panic in alloy-dyn-abi-1.5.2 (`range end index 4 out of range for slice of length 0`) when running `expectRevert` against a zero-arg custom error encoded via `abi.encodeWithSelector(...)` with no args. The `bytes4` overload bypasses the buggy decode path. Bulk-sed'd across all test files (~92 sites in 20 files). Behaviour unchanged — both forms expect the same 4-byte selector. Closes the `rainix-sol-test` and `test` CI failures across the stack. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
hardyjosh
pushed a commit
that referenced
this pull request
May 11, 2026
Two unrelated CI fixes for the audit stack, bundled because both are blocking every downstream PR's CI. 1. **subgraph/subgraph.yaml event signatures** — the corp-actions stack (PRs #20–#26) added a `CorporateActionPauseConfig` struct field to `PythOracleAdapterInitialized` and `MultiPythOracleAdapterInitialized` event payloads but didn't update the subgraph. As a result the `test` job (graph codegen) fails across every PR in the stack — "Event with signature ... not present in ABI". Subgraph handlers don't reference the new `pauseConfig` tuple, so only the YAML signature lines change. 2. **`vm.expectRevert(abi.encodeWithSelector(ZeroArgError.selector))` → `vm.expectRevert(ZeroArgError.selector)`** — foundry-nightly 1.6 has an ABI-decoder panic in alloy-dyn-abi-1.5.2 (`range end index 4 out of range for slice of length 0`) when running `expectRevert` against a zero-arg custom error encoded via `abi.encodeWithSelector(...)` with no args. The `bytes4` overload bypasses the buggy decode path. Bulk-sed'd across all test files (~92 sites in 20 files). Behaviour unchanged — both forms expect the same 4-byte selector. Closes the `rainix-sol-test` and `test` CI failures across the stack. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
hardyjosh
pushed a commit
that referenced
this pull request
May 11, 2026
Two unrelated CI fixes for the audit stack, bundled because both are blocking every downstream PR's CI. 1. **subgraph/subgraph.yaml event signatures** — the corp-actions stack (PRs #20–#26) added a `CorporateActionPauseConfig` struct field to `PythOracleAdapterInitialized` and `MultiPythOracleAdapterInitialized` event payloads but didn't update the subgraph. As a result the `test` job (graph codegen) fails across every PR in the stack — "Event with signature ... not present in ABI". Subgraph handlers don't reference the new `pauseConfig` tuple, so only the YAML signature lines change. 2. **`vm.expectRevert(abi.encodeWithSelector(ZeroArgError.selector))` → `vm.expectRevert(ZeroArgError.selector)`** — foundry-nightly 1.6 has an ABI-decoder panic in alloy-dyn-abi-1.5.2 (`range end index 4 out of range for slice of length 0`) when running `expectRevert` against a zero-arg custom error encoded via `abi.encodeWithSelector(...)` with no args. The `bytes4` overload bypasses the buggy decode path. Bulk-sed'd across all test files (~92 sites in 20 files). Behaviour unchanged — both forms expect the same 4-byte selector. Closes the `rainix-sol-test` and `test` CI failures across the stack. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
hardyjosh
pushed a commit
that referenced
this pull request
May 11, 2026
Two unrelated CI fixes for the audit stack, bundled because both are blocking every downstream PR's CI. 1. **subgraph/subgraph.yaml event signatures** — the corp-actions stack (PRs #20–#26) added a `CorporateActionPauseConfig` struct field to `PythOracleAdapterInitialized` and `MultiPythOracleAdapterInitialized` event payloads but didn't update the subgraph. As a result the `test` job (graph codegen) fails across every PR in the stack — "Event with signature ... not present in ABI". Subgraph handlers don't reference the new `pauseConfig` tuple, so only the YAML signature lines change. 2. **`vm.expectRevert(abi.encodeWithSelector(ZeroArgError.selector))` → `vm.expectRevert(ZeroArgError.selector)`** — foundry-nightly 1.6 has an ABI-decoder panic in alloy-dyn-abi-1.5.2 (`range end index 4 out of range for slice of length 0`) when running `expectRevert` against a zero-arg custom error encoded via `abi.encodeWithSelector(...)` with no args. The `bytes4` overload bypasses the buggy decode path. Bulk-sed'd across all test files (~92 sites in 20 files). Behaviour unchanged — both forms expect the same 4-byte selector. Closes the `rainix-sol-test` and `test` CI failures across the stack. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
hardyjosh
pushed a commit
that referenced
this pull request
May 11, 2026
Two unrelated CI fixes for the audit stack, bundled because both are blocking every downstream PR's CI. 1. **subgraph/subgraph.yaml event signatures** — the corp-actions stack (PRs #20–#26) added a `CorporateActionPauseConfig` struct field to `PythOracleAdapterInitialized` and `MultiPythOracleAdapterInitialized` event payloads but didn't update the subgraph. As a result the `test` job (graph codegen) fails across every PR in the stack — "Event with signature ... not present in ABI". Subgraph handlers don't reference the new `pauseConfig` tuple, so only the YAML signature lines change. 2. **`vm.expectRevert(abi.encodeWithSelector(ZeroArgError.selector))` → `vm.expectRevert(ZeroArgError.selector)`** — foundry-nightly 1.6 has an ABI-decoder panic in alloy-dyn-abi-1.5.2 (`range end index 4 out of range for slice of length 0`) when running `expectRevert` against a zero-arg custom error encoded via `abi.encodeWithSelector(...)` with no args. The `bytes4` overload bypasses the buggy decode path. Bulk-sed'd across all test files (~92 sites in 20 files). Behaviour unchanged — both forms expect the same 4-byte selector. Closes the `rainix-sol-test` and `test` CI failures across the stack. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Collaborator
Author
|
Subsumed by #237 (soldeer migration brings st0x-deploy 0.1.0 directly). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps lib/st0x.deploy from 766b468 to 9955248 (origin/main) and adds the st0x.deploy/= remapping. The newer ref exposes ICorporateActionsV1 — the interface the corporate-action-aware oracle work (RAI-318..328) consumes — along with its supporting libs and the cancelled-node sentinel semantics those rely on.
No functional changes to oracle code in this commit; later PRs in the stack import from the new remapping.
Summary by CodeRabbit