refactor(test): extract shared MockCorporateActions fixture (audit #207)#226
Closed
hardyjosh wants to merge 1 commit into
Closed
refactor(test): extract shared MockCorporateActions fixture (audit #207)#226hardyjosh wants to merge 1 commit into
hardyjosh wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced May 11, 2026
Collaborator
Author
This was referenced May 11, 2026
Closed
Closed
Three separate test files each defined their own MockCorporateActions mock of ICorporateActionsV1, with subtly different setter signatures. Drift across these copies has already burned us — PR #221 had to update the no-match sentinel in all three; a future ICorporateActionsV1 interface change risks updating only two of three. Extracts the mock to `test/mocks/MockCorporateActions.sol` using the most expressive of the three signatures (3-arg setters with caller-supplied cursor). All three call sites now import the shared mock. Behaviour unchanged: NODE_NONE no-match sentinel preserved from PR #221; existing test assertions still pass. Closes #207. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
hardyjosh
force-pushed
the
fix/audit-prodfork-hardening
branch
from
e30bfc0 to
6903113
Compare
hardyjosh
force-pushed
the
fix/audit-mock-corporate-actions-dedup
branch
from
44287c9 to
1776f5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three separate test files each defined their own MockCorporateActions
mock of ICorporateActionsV1, with subtly different setter signatures.
Drift across these copies has already burned us — PR #221 had to
update the no-match sentinel in all three; a future ICorporateActionsV1
interface change risks updating only two of three.
Extracts the mock to
test/mocks/MockCorporateActions.solusing themost expressive of the three signatures (3-arg setters with
caller-supplied cursor). All three call sites now import the shared
mock. Behaviour unchanged: NODE_NONE no-match sentinel preserved from
PR #221; existing test assertions still pass.
Closes #207.
Co-Authored-By: Claude Opus 4.7 noreply@anthropic.com