test: auto-pause revert propagation through protocol adapters (RAI-321)#24
Open
hardyjosh wants to merge 1 commit into
Open
test: auto-pause revert propagation through protocol adapters (RAI-321)#24hardyjosh wants to merge 1 commit into
hardyjosh wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced May 9, 2026
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 9, 2026
hardyjosh
force-pushed
the
feat/auto-pause-base-adapter
branch
from
4c711c5 to
140fb0f
Compare
hardyjosh
force-pushed
the
test/auto-pause-propagation
branch
2 times, most recently
from
1473d68 to
8771cc3
Compare
hardyjosh
force-pushed
the
feat/auto-pause-base-adapter
branch
2 times, most recently
from
4eb86c3 to
9093228
Compare
hardyjosh
force-pushed
the
test/auto-pause-propagation
branch
from
8771cc3 to
f286afe
Compare
This was referenced May 11, 2026
Closed
Closed
hardyjosh
force-pushed
the
test/auto-pause-propagation
branch
from
f286afe to
e3dd304
Compare
hardyjosh
force-pushed
the
feat/auto-pause-base-adapter
branch
from
5f986f2 to
d538ab2
Compare
hardyjosh
force-pushed
the
test/auto-pause-propagation
branch
2 times, most recently
from
e2683f3 to
e4530d2
Compare
hardyjosh
force-pushed
the
feat/auto-pause-base-adapter
branch
from
d538ab2 to
b26969b
Compare
hardyjosh
force-pushed
the
test/auto-pause-propagation
branch
from
e4530d2 to
8a87749
Compare
hardyjosh
force-pushed
the
test/auto-pause-propagation
branch
from
8a87749 to
c17c99c
Compare
hardyjosh
force-pushed
the
feat/auto-pause-base-adapter
branch
from
b26969b to
73f1220
Compare
This was referenced May 26, 2026
hardyjosh
force-pushed
the
test/auto-pause-propagation
branch
from
c17c99c to
5afd61b
Compare
hardyjosh
force-pushed
the
feat/auto-pause-base-adapter
branch
from
73f1220 to
2ed0a7f
Compare
Wires up the full Oracle → Registry → Protocol-adapter chain (Passthrough for Aave/Compound and Morpho both) and verifies that auto-pause reverts surface end-to-end with their original selectors and effectiveTime payload — distinguishable from OraclePausedManual and from each other. Four checks: * Happy path: no scheduled action → both adapters return a price * PassthroughProtocolAdapter (latestAnswer + latestRoundData) propagates OraclePausedCorporateAction(effectiveTime) unchanged * MorphoProtocolAdapter.price() propagates the same revert * Manual-pause precedence is preserved through the chain (manual + auto both armed → manual error reported) Uses the shared `test/mocks/MockCorporateActions.sol` stub introduced in PR #22, which returns the documented NODE_NONE = type(uint256).max sentinel on no-match, matching the real ICorporateActionsV1 contract. Scope note: RAI-321 also asks for fork tests against a real st0x.deploy vault scheduling actions through the authoriser. That's deferred to RAI-327 (testnet deploy + dry run) since no production vault has the new corporate-actions facet deployed yet — there's nothing real to fork against. The mock here exercises the same chain wiring; once a vault is deployed, the fork test is an additive layer.
hardyjosh
force-pushed
the
feat/auto-pause-base-adapter
branch
from
2ed0a7f to
4b1991a
Compare
hardyjosh
force-pushed
the
test/auto-pause-propagation
branch
from
5afd61b to
1615d4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires up the full Oracle → Registry → Protocol-adapter chain (Passthrough for Aave/Compound and Morpho both) and verifies that auto-pause reverts surface end-to-end with their original selectors and effectiveTime payload — distinguishable from OraclePausedManual and from each other.
Four checks:
Scope note: RAI-321 also asks for fork tests against a real st0x.deploy vault scheduling actions through the authoriser. That's deferred to RAI-327 (testnet deploy + dry run) since no production vault has the new corporate-actions facet deployed yet — there's nothing real to fork against. The mock here exercises the same chain wiring; once a vault is deployed, the fork test is an additive layer.