Skip to content

sharing 1/7: Transfer library (enums, comms, serialization, test infra)#8125

Open
keithharvey wants to merge 1 commit into
sharing_tab_mergeablefrom
sharing/01-foundations
Open

sharing 1/7: Transfer library (enums, comms, serialization, test infra)#8125
keithharvey wants to merge 1 commit into
sharing_tab_mergeablefrom
sharing/01-foundations

Conversation

@keithharvey

@keithharvey keithharvey commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator

📚 Stacked split of #5704 — review bottom-up

Each PR merges into the one below it; together they reproduce the sharing_tab branch (bar one intentional change — index.lua lazy-loads the mode helpers).


Stack 1 of 7 splitting #5704. The leaf layer everything builds on — pure plumbing, no policy/modes/economy logic.

  • team_transfer/*transfer_enums, sharing_mode_enums, comms (resource / unit / take / tech_blocking), serialization_helpers, team_resource_data, unit_sharing_categories, tech_blocking_shared, policy_events
  • messaging + i18n — lua_rules_msg, game_message, i18n interpolate; types/Spring.lua
  • test infrastructure — spec builders + spec_helper. index.lua now lazy-loads the mode helpers (which pull the pipeline), so the lower layers stay pipeline-free. Includes the policy_events / unit_sharing_categories specs.

Compiles and tests standalone.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Integration Test Results

14 tests  ±0   6 ✅ ±0   3s ⏱️ ±0s
 1 suites ±0   8 💤 ±0 
 1 files   ±0   0 ❌ ±0 

Results for commit 9ce16f6. ± Comparison against base commit d4e6e02.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant