Skip to content

sharing 4/7: Transfer runtime (controllers, economy boundary, gadget swap)#8062

Open
keithharvey wants to merge 1 commit into
sharing_policy_corefrom
sharing/02-transfer-runtime
Open

sharing 4/7: Transfer runtime (controllers, economy boundary, gadget swap)#8062
keithharvey wants to merge 1 commit into
sharing_policy_corefrom
sharing/02-transfer-runtime

Conversation

@keithharvey

@keithharvey keithharvey commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

📚 Stacked split of #5704 — review bottom-up

Each PR merges into the one below it; together they reproduce the sharing_tab branch (bar one intentional change — index.lua lazy-loads the mode helpers).


Stack 4 of 7 splitting #5704. Builds on 3/7.

The behavior switch. Replaces the old sharing/restriction gadgets with two unified controllers and routes all team-resource reads/writes through the GG economy boundary.

  • add game_resource_transfer_controller (defines GG.GetTeamResources/AddTeamResource/SetTeamShareLevel) and game_unit_transfer_controller
  • add cmd_take, allied unit reclaim / partial resurrection / ally geo-mex modes; rename game_disable_assist_allygame_allied_assist_mode
  • delete game_tax_resource_sharing, game_no_share_to_enemy, game_prevent_excessive_share, game_restrict_unit_sharing, game_disable_unit_sharing, game_restrict_resurrection
  • migrate all Spring.*TeamResource* call sites to the GG.* boundary
  • gadgets/modrules registration, controller spec, in-game test widgets

@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Integration Test Results

17 tests  +3   6 ✅ ±0   6s ⏱️ +3s
 1 suites ±0   8 💤 ±0 
 1 files   ±0   3 ❌ +3 

For more details on these failures, see this check.

Results for commit 7504241. ± Comparison against base commit 2fb534e.

♻️ This comment has been updated with latest results.

@keithharvey keithharvey force-pushed the sharing/02-transfer-runtime branch from 1f5b919 to aff6801 Compare June 22, 2026 19:05
@keithharvey keithharvey force-pushed the sharing/01-foundations branch from 1d313d0 to e40bb94 Compare June 24, 2026 07:58
@keithharvey keithharvey force-pushed the sharing/02-transfer-runtime branch from aff6801 to 9178a16 Compare June 24, 2026 07:58
@keithharvey keithharvey force-pushed the sharing/01-foundations branch from e40bb94 to d2097ec Compare June 25, 2026 21:37
@keithharvey keithharvey force-pushed the sharing/02-transfer-runtime branch from 9178a16 to 5dd928e Compare June 25, 2026 21:37
@keithharvey keithharvey changed the title sharing 2/4: transfer runtime (controllers, economy boundary, gadget swap) sharing 2/5: transfer runtime (controllers, economy boundary, gadget swap) Jun 25, 2026
@keithharvey keithharvey force-pushed the sharing/01-foundations branch from d2097ec to 959aac8 Compare June 25, 2026 22:26
@keithharvey keithharvey force-pushed the sharing/02-transfer-runtime branch from 5dd928e to 87d566f Compare June 25, 2026 22:26
@keithharvey keithharvey changed the title sharing 2/5: transfer runtime (controllers, economy boundary, gadget swap) sharing 3/6: transfer runtime (controllers, economy boundary, gadget swap) Jun 28, 2026
@keithharvey keithharvey force-pushed the sharing/01-foundations branch from 959aac8 to ba33b5f Compare June 28, 2026 06:51
@keithharvey keithharvey force-pushed the sharing/02-transfer-runtime branch 3 times, most recently from c9367a4 to 6c0e5d8 Compare June 28, 2026 07:28
@keithharvey keithharvey force-pushed the sharing/01-foundations branch from 9d6f82e to 4ad5fe3 Compare June 28, 2026 07:28
@keithharvey keithharvey changed the base branch from sharing/01-foundations to sharing/modes-economy June 28, 2026 07:28
@keithharvey keithharvey changed the title sharing 3/6: transfer runtime (controllers, economy boundary, gadget swap) sharing 4/7: Transfer runtime (controllers, economy boundary, gadget swap) Jun 28, 2026
@keithharvey keithharvey force-pushed the sharing/02-transfer-runtime branch from 6c0e5d8 to 7504241 Compare June 28, 2026 09:02
@keithharvey keithharvey force-pushed the sharing/modes-economy branch from 84cfbd0 to 2fb534e Compare June 28, 2026 09:02
Base automatically changed from sharing/modes-economy to sharing_policy_core June 28, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant