Skip to content

sharing 6/7: Sharing Tab UI#8064

Open
keithharvey wants to merge 1 commit into
sharing/03-tech-keystonefrom
sharing/04-sharing-tab-ui
Open

sharing 6/7: Sharing Tab UI#8064
keithharvey wants to merge 1 commit into
sharing/03-tech-keystonefrom
sharing/04-sharing-tab-ui

Conversation

@keithharvey

@keithharvey keithharvey commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

📚 Stacked split of #5704 — review bottom-up

Each PR merges into the one below it; together they reproduce the sharing_tab branch (bar one intentional change — index.lua lazy-loads the mode helpers).


Stack 6 of 7 splitting #5704. Builds on 5/7.

The player-facing tab and supporting widgets:

  • gui_advplayerslist sharing tab + modules, plus team_transfer/gui_advplayerlist/* policy/resource/validation + unsynced comms helpers
  • gui_top_bar share/conversion areas, gui_chat, cmd_share_unit, cmd_take widget, selectedunits + DrawPrimitiveAtUnit shaders
  • interface.json / tips.json strings

@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Integration Test Results

18 tests  ±0   9 ✅ +2   20s ⏱️ +12s
 1 suites ±0   8 💤 ±0 
 1 files   ±0   1 ❌  - 2 

For more details on these failures, see this check.

Results for commit 5ec9c9b. ± Comparison against base commit b77838c.

♻️ This comment has been updated with latest results.

@keithharvey keithharvey force-pushed the sharing/04-sharing-tab-ui branch from 7911463 to 41cb9cf Compare June 22, 2026 08:26
@keithharvey keithharvey force-pushed the sharing/03-tech-keystone branch from 0ac6d63 to 495ddd8 Compare June 22, 2026 18:03
@keithharvey keithharvey force-pushed the sharing/04-sharing-tab-ui branch from 41cb9cf to b05ed42 Compare June 22, 2026 18:03
@keithharvey keithharvey force-pushed the sharing/03-tech-keystone branch from 495ddd8 to e44eafa Compare June 22, 2026 19:05
@keithharvey keithharvey force-pushed the sharing/04-sharing-tab-ui branch from b05ed42 to 04252b9 Compare June 22, 2026 19:06
@keithharvey keithharvey force-pushed the sharing/03-tech-keystone branch from e44eafa to 470079c Compare June 24, 2026 07:58
@keithharvey keithharvey force-pushed the sharing/04-sharing-tab-ui branch 2 times, most recently from daa0b5b to 6b37fb4 Compare June 25, 2026 21:37
@keithharvey keithharvey force-pushed the sharing/03-tech-keystone branch from 470079c to 5da130f Compare June 25, 2026 21:37
@keithharvey keithharvey changed the title sharing 4/4: Sharing Tab UI sharing 4/5: Sharing Tab UI Jun 25, 2026
@keithharvey keithharvey force-pushed the sharing/04-sharing-tab-ui branch from 6b37fb4 to b58d6eb Compare June 25, 2026 22:26
@keithharvey keithharvey force-pushed the sharing/03-tech-keystone branch from 5da130f to 7fd7297 Compare June 25, 2026 22:26
@keithharvey keithharvey changed the title sharing 4/5: Sharing Tab UI sharing 5/6: Sharing Tab UI Jun 28, 2026
@keithharvey keithharvey force-pushed the sharing/04-sharing-tab-ui branch from b58d6eb to f22459c Compare June 28, 2026 06:51
@keithharvey keithharvey force-pushed the sharing/03-tech-keystone branch 2 times, most recently from 33bc2cb to ea791fa Compare June 28, 2026 07:24
@keithharvey keithharvey force-pushed the sharing/04-sharing-tab-ui branch 2 times, most recently from 9e8fe32 to aca03b5 Compare June 28, 2026 07:28
@keithharvey keithharvey force-pushed the sharing/03-tech-keystone branch from ea791fa to 73d078b Compare June 28, 2026 07:28
@keithharvey keithharvey changed the title sharing 5/6: Sharing Tab UI sharing 6/7: Sharing Tab UI Jun 28, 2026
@keithharvey keithharvey force-pushed the sharing/03-tech-keystone branch from 73d078b to b77838c Compare June 28, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant