Repository navigation
feat(kiosk): mark first-come chores as up for grabs - #1247
Merged
Merged
Conversation
A first-come chore sits on every child's list until one of them finishes it, but the kiosk drew it like any other chore, so a child couldn't tell a race from their own job. On the kiosk's child screen it now gets a dashed accent border, a tinted background and an "Up for grabs - first one wins" tag. Done, waiting and missed rows are left alone. - New string kiosk.up_for_grabs in all locales, with the split bundles - Test: only the first-come chore is marked - Docs: Kiosk Mode page
github-actions
Bot
added
documentation
Owner
|
Thanks for this. It's a nice, tidy change, and it's the right gap to fill on the kiosk. Two small things before I take it to testing:
CI is green. Once those are in, I'll test it on my dev instance across the designs. |
…rom needs-check The tag used fixed dark ink on a solid warn fill, which only reached 3.7:1 on the Graphite design. It now uses the design's own text colour on a 28% warn tint, which is at least 5.5:1 in every design, light and dark. On a first-come chore that also needs approval, the tag sat next to the warn-coloured "A grown-up will check" tag. It now has a stronger tint and a dashed border matching the row's, so the two read apart. Adds a wiki screenshot of that row.
Contributor
Author
|
I added a photo to the wiki that shows how they look together after tweaking things based on your feedback 
|
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On the kiosk's child screen, a first-come chore looked like any other chore. It sits on every child's list until one of them finishes it, so a child couldn't tell a race from their own job. It now gets a dashed accent border, a tinted background and an orange "Up for grabs — first one wins" tag next to the points.
Done, waiting-for-a-grown-up and missed rows are left alone, as is every chore that isn't
first_come.Related issue
N/A. The motivation is above: with a wall tablet and
first_comechores, nothing on the kiosk says which chores are shared. I can open an issue first if you'd rather agree the approach there.Type of change
How has this been tested?
taskmate-kiosk-card.test.cjs: with onefirst_comechore and one ordinary chore due, only the first-come row is marked and the tag appears once. All 89 kiosk tests pass (node --test tests/frontend/taskmate-kiosk-card.test.cjs).hasswith first-come, alternating and ordinary chores, and checked the result by eye.Note: I added the key to each locale's
cards.jsonbundle by hand instead of runningscripts/split_locales.py, so please let CI's--checkconfirm they match.ruff check .locally (matches theRuffCI check)pytestlocally (matches theRun testsCI check)Checklist
manifest.jsonversionif this is a release-bound change (left to the maintainer's release)README/ docs where relevant (Kiosk Mode wiki page)Preview of change
