filter ACL forbidden paths from search query

[icewind1991]

Currently, the logic for removing files the user doesn't have access to from search is done as a post-processing step.

While this filters out the correct entries, it means that the number of returned results is less than the limit asked for (or even 0). Which the search logic interprets as there being no more results.

By applying the filtering as part of the query, we return the number of results asked for.

[icewind1991]

Fixes nextcloud/server#60306

[icewind1991]

/backport to stable34

[icewind1991]

/backport to stable33

[danxuliu]

@icewind1991 @provokateurin While the fix solves the issue for users with forbidden paths it breaks searching for users without any forbidden path. It can be reproduced with the steps from nextcloud/server#60306 but searching as the user manager instead of as the user restricted. The E2E test from #4675 also fails for the search done as user manager.

Adding something like:

		if (empty($forbiddenPaths)) {
			return new SearchBinaryOperator(ISearchBinaryOperator::OPERATOR_AND, []);
		}

to getSearchFilter() make it work as expected for both manager and restricted, but I did not dig into the issue.

Besides that, would it be possible to backport this pull request and the follow up also to stable32? Thanks!

[icewind1991]

/backport to stable32