Add E2E test for searching with restricted ACL read permissions#4675
Open
danxuliu wants to merge 1 commit into
Open
Add E2E test for searching with restricted ACL read permissions#4675danxuliu wants to merge 1 commit into
danxuliu wants to merge 1 commit into
Conversation
danxuliu
force-pushed
the
add-e2e-test-for-searching-with-restricted-acl-read-permissions
branch
from
8dcb0f1 to
2cd7b1b
Compare
danxuliu
force-pushed
the
add-e2e-test-for-searching-with-restricted-acl-read-permissions
branch
2 times, most recently
from
698659d to
47b97a5
Compare
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
force-pushed
the
add-e2e-test-for-searching-with-restricted-acl-read-permissions
branch
from
47b97a5 to
bed0cf3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a E2E test for the issue in nextcloud/server#60306.
Although the issue seems to be in server itself it looks like a good use case to have an explicit test for it in the groupfolders app (and even if not at least provides an easy way to test the fix :-) ).This will be fixed in the groupfolders app itself in #4745 and its follow up #4817 Those pull requests already include a unit test for the issue, so this E2E test may or may not be needed. Up to the maintainers :-)It is worth noting, though, that I noticed the regression in #4745 when I rebased this pull request and the test did not pass yet ;-)
It will need to be kept as a draft until the issue is fixed, but the test itself is ready for review.