fix: fix search results when no paths are forbidden#4817
Merged
Conversation
3 tasks
danxuliu
approved these changes
Jun 22, 2026
danxuliu
left a comment
danxuliu
left a comment
Member
There was a problem hiding this comment.
Tested and works 👍
Nevertheless, maybe it would be better to use if (count($forbiddenPaths) === 0) { or if ($forbiddenPaths === []) { instead of the current if (empty($forbiddenPaths)) {? (which I suggested myself 🤦, but I always forget that in PHP empty() is not only about arrays)
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
acl-search-no-forbidden
branch
from
e25c136 to
4fb4644
Compare
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure why
not in []doesn't just become a noop.🤖 AI (if applicable)