Skip to content

Go: a lone seat posts a challenge - #461

Merged
aaylward merged 2 commits into
mainfrom
claude/hopeful-ramanujan-uwueor
Oct 19, 2026
Merged

aaylward merged 2 commits into
mainfrom
claude/hopeful-ramanujan-uwueor

Conversation

@aaylward

Copy link
Copy Markdown
Contributor

UI for muchq/MoonBase#1679 (muchq/MoonBase#1668 phase 2).

  • Alone at a waiting go table, the board and clock picker posts a challenge ("Post challenge", then "Update challenge"); with two seats it starts the game as before.
  • GoView.terms is said in the status ("Challenge posted: 13×13, komi 6.5, 5+3. Whoever joins starts on it."), to seats and watchers, and preselects the picker.
  • The lobby already labels a table with terms "Accept" for every game.

Deploy order: merge after muchq/MoonBase#1679 deploys; an older hub refuses the challenge move.

Tests: useGoTable posts the move; GoTable posts alone, shows and updates posted terms, and a watcher posts nothing. Watched red first.


Generated by Claude Code

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
muchq 744d811 Commit Preview URL

Branch Preview URL
Oct 19 2026, 07:42 PM

@cursor

cursor Bot commented Oct 19, 2026

Copy link
Copy Markdown

Review findings (aligned with chess’s challenge UI):

  1. With two seats and residual terms, status still said “Whoever joins starts on it” while the CTA was Start.
  2. A posted clock outside the local CLOCKS map fell back to 10+5, so Update challenge could silently rewrite hub-valid clocks (e.g. 1+0).

Follow-up #462 includes this PR’s commit and those fixes. Prefer #462.

@cursor

cursor Bot commented Oct 19, 2026

Copy link
Copy Markdown

Review

Sorry for the noise earlier — opening #462 was wrong for a review ask; that PR is closed.

Medium — two-seat status still waits for a joiner

GoTable.tsx always appends “Whoever joins starts on it.” whenever view.terms is set. With two seats the CTA is already Start / startTable, so status and the button disagree. Chess gates that clause on alone (watching || !alone ? posted : …Whoever joins…).

Medium — posted clocks outside CLOCKS can be rewritten

postedClock only matches the three local presets. A hub-valid clock like 1+0 (pinned in MoonBase#1679) falls back to 10+5 in the picker, so Update challenge (or two-seat Start on residual terms) silently posts the preset. Chess injects the posted clock into the offered map so Update preserves it.

Low — README still reads challenges as chess-only

In-repo docs describe challenge/Accept for chess; this PR adds the go path with no README note. Deploy order is only in the PR body (fine), but the lobby narrative should mention go once this lands.

Coverage note

Happy path is covered (alone post, update in-preset, watcher). The two mediums above are unpinned: no two-seat + residual-terms status assertion, no out-of-preset clock preservation test.

Otherwise the altitude looks right for UI-only phase 2 against MoonBase#1679: wire challenge / GoView.terms, lone post vs two-seat Start, watcher posts nothing. CI green.

Copy link
Copy Markdown
Contributor Author

Both mediums fixed in 744d811, as chess does it:

  • The status adds "Whoever joins starts on it." only for the lone seat. Two seats or a watcher see just the posted terms.
  • A posted clock outside the presets is offered under its own label (1+0), so Update keeps it.

Each has a new test: two seats on residual terms, and an out-of-preset clock surviving Update.

README: left as is. It has no Go section to put the note in; the hub's README covers go's challenges.


Generated by Claude Code

@aaylward
aaylward merged commit 234e795 into main Oct 19, 2026
2 checks passed
@aaylward
aaylward deleted the claude/hopeful-ramanujan-uwueor branch October 19, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants