Repository navigation
games_hub: go takes challenges - #1679
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
iili | f97f3d7 | Commit Preview URL Branch Preview URL |
Oct 19 2026, 06:14 PM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
1d4-web | f97f3d7 | Commit Preview URL Branch Preview URL |
Oct 19 2026, 06:13 PM |
Review: go takes challengesVerdict: Approve. Clean #1668 phase-2 cut on the #1678 terms spine: What worksShape. Rules. Stored bytes. Tests. E2e: post shows in room+view, join starts on terms, defaults, rules refusals. Wire goldens for command / view terms / room line (panel Non-blocking / ops
Tip |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
ast-lol | f97f3d7 | Commit Preview URL Branch Preview URL |
Oct 19 2026, 06:15 PM |
CI:
|
#1668 phase 2.
GoTerms{size, komi, clock}joinsHostedTerms; go's adapterStartis nowGoTerms, so a startGame and a challenge are one shape.challenge: GoStartGameposts terms, the seat that fills the table starts on them,GoView.termsshows them while waiting, and the lobby lists them ("9×9 · komi 5.5 · 1+0").go::CheckRules(the engine's start check minus the seats). Stored terms that fail it read as malformed.{"terms":{"size","komi","initialMs","incrementMs"}}, pinned both ways beside chess's. Go's engine encoding has no top-levelterms.ClockLineis shared by chess's and go's lobby lines.Handicap is not here: the engine has no handicap placement yet.
Rollback: a pre-change binary can't read an open go challenge's row and drops it from the lobby, logged; the row survives and returns on roll-forward.
Tests:
//domains/games/...green with Postgres, no skips. Wire goldens pin the challenge command,GoView.termsbytes and the room line, plus in-band bound and rules refusals. The first tests were written with the code, not watched red first.scripts/mutation-checkkills every guard instead: capability off, FilledStart, the post-time rules check, the stored-terms check, the view's terms, the lobby line.Review panel ran; fixups in f97f3d7 (wire goldens, refusal reasons, README and model docs). Kept as is: go's defaults live on
GoTerms(chess keeps its defaults in its adapter).UI: muchq/muchq.github.io#461, to merge after this deploys.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Xae1QBa2qHX32DPVGSq19F