Repository navigation
Conversation
Gate the joiner clause on being alone, keep posted clocks outside the local presets in the picker, and document go challenges beside chess. Co-authored-by: Andy Aylward <aaylward@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds on #461 (UI for MoonBase#1679 / #1668 phase 2) and aligns the challenge chrome with chess:
challenge; with two seats, Start as beforeGoView.termsin the status, to seats and watchers; joiner clause only while alonePrefer this PR over #461; it includes that commit plus the polish above.
Deploy order: merge after MoonBase#1679 deploys; an older hub refuses the
challengemove.Verification
npm run typechecknpm run lintnpm run test:run(109 files, 1,643 tests)npm run build