Conversation
Owner
|
Thanks @skrhakv good catch. The citation was indeed wrong, so I've corrected it directly across the docs (it was mis-attributed in a couple of spots the PR didn't touch too), and you'll be credited in the future changelog. Appreciate you flagging it, and I'd genuinely enjoy comparing notes on cryptic sites sometime. Closing since the fix is in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there, exciting to see a new tool utilizing the CryptoBench dataset! I was just going through your docs and found that the citation is incorrect, therefore I created this PR to correct it. Feel free to review it & merge if there are no issues.
Also, always happy to chat with a cryptic binding site enthusiast!
Vit