fix(highlight): resolve highlights relative to the frame of the locator - #42868
Conversation
HighlightController resolved every selector from the main frame, so frame.locator(...).highlight() highlighted elements in the page instead of the frame. Thread the frame through the highlight entry and key the entries by frame, so the same selector can be highlighted from different frames. Fixes: microsoft#42850
Test results for "tests 1"4 flaky52160 passed, 1253 skipped Merge workflow run. |
Test results for "MCP"2 failed 8690 passed, 1474 skipped Merge workflow run. |
🟢 Both failures are pre-existing flakes — this PR is clearHi, I'm the Playwright bot and I triaged the red CI here. The two failures are both MCP tests that DetailsThe diff is confined to Pre-existing flake / infra
I'm a first pass, not the final word — but nothing in the evidence points at this change. Triaged by the Playwright bot - agent run |
cd16010
into
microsoft:main
Summary
HighlightControllerresolved every selector from the main frame, soframe.locator(...).highlight()highlighted elements in the page instead of the frameFixes #42850