You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
playwright-cli install-browser --no-shell was rejected with Unknown option: --shell: minimist parses it as { shell: false }, but the command declares no-shell. Flag validation now accepts negated flags declared as no-*.
Drop the unused noShell option from installBrowsers.
8 flaky⚠️ [chromium-library] › library/browsercontext-page-event.spec.ts:160 › should work with Shift-clicking `@chromium-ubuntu-22.04-arm-node20` ⚠️ [chromium-library] › library/browsercontext-page-event.spec.ts:173 › should work with Ctrl-clicking `@chromium-ubuntu-22.04-arm-node20` ⚠️ [chromium-library] › library/video.spec.ts:690 › screencast › should capture full viewport `@chromium-ubuntu-22.04-arm-node20` ⚠️ [chromium-library] › library/video.spec.ts:762 › screencast › should work with video+trace `@chromium-ubuntu-22.04-arm-node20` ⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › should support dismissing the dialog multiple times `@chromium-ubuntu-22.04-node20` ⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20` ⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20` ⚠️ [webkit-page] › page/page-leaks.spec.ts:136 › expect should not leak `@webkit-ubuntu-22.04-node20`
🟢 CI is clear — the one failure is a known Windows/Firefox flake
Hi, I'm the Playwright bot and I triaged the CI failures here.
[firefox] › mcp/cli-session.spec.ts:54 › idle timeout shuts the session down @mcp-windows-latest-firefox is the only red test, and it fails on plenty of SHAs this PR has nothing to do with. Nothing in the diff reaches it.
The diff also doesn't reach it: validateFlags() only gains two extra continue branches, so it is strictly more permissive than before, and --idle-timeout=3000 parses to a non-false value that the new args[key] === false branch never touches. The other three files are the install-browser path and a new test.
Flaky (passed on retry)
The 8 warnings in the "tests 1" report (browsercontext-page-event, video, beforeunload, browsercontext-cookies-third-party, page-leaks) all went green on retry and are unrelated to CLI flag parsing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
playwright-cli install-browser --no-shellwas rejected withUnknown option: --shell: minimist parses it as{ shell: false }, but the command declaresno-shell. Flag validation now accepts negated flags declared asno-*.noShelloption frominstallBrowsers.Fixes #42804