Skip to content

fix(cli): accept install-browser --no-shell - #42871

Merged
Yury Semikhatsky (yury-s) merged 1 commit into
microsoft:mainfrom
yury-s:fix-42804
Sep 23, 2026
Merged

Yury Semikhatsky (yury-s) merged 1 commit into
microsoft:mainfrom
yury-s:fix-42804

Conversation

@yury-s

Copy link
Copy Markdown
Member

Summary

  • playwright-cli install-browser --no-shell was rejected with Unknown option: --shell: minimist parses it as { shell: false }, but the command declares no-shell. Flag validation now accepts negated flags declared as no-*.
  • Drop the unused noShell option from installBrowsers.

Fixes #42804

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

8 flaky ⚠️ [chromium-library] › library/browsercontext-page-event.spec.ts:160 › should work with Shift-clicking `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/browsercontext-page-event.spec.ts:173 › should work with Ctrl-clicking `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:690 › screencast › should capture full viewport `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:762 › screencast › should work with video+trace `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › should support dismissing the dialog multiple times `@chromium-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`
⚠️ [webkit-page] › page/page-leaks.spec.ts:136 › expect should not leak `@webkit-ubuntu-22.04-node20`

52148 passed, 1253 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [firefox] › mcp/cli-session.spec.ts:54 › idle timeout shuts the session down @mcp-windows-latest-firefox

8704 passed, 1474 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 CI is clear — the one failure is a known Windows/Firefox flake

Hi, I'm the Playwright bot and I triaged the CI failures here.

[firefox] › mcp/cli-session.spec.ts:54 › idle timeout shuts the session down @mcp-windows-latest-firefox is the only red test, and it fails on plenty of SHAs this PR has nothing to do with. Nothing in the diff reaches it.

Details

Pre-existing flake / infra

Flaky (passed on retry)

  • The 8 warnings in the "tests 1" report (browsercontext-page-event, video, beforeunload, browsercontext-cookies-third-party, page-leaks) all went green on retry and are unrelated to CLI flag parsing.

Triaged by the Playwright bot - agent run

@yury-s
Yury Semikhatsky (yury-s) merged commit 0406789 into microsoft:main Sep 23, 2026
45 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CLI]: install-browser --no-shell is rejected with "Unknown option: --shell"

2 participants