Skip to content

fix(highlight): resolve highlights in the frame of the locator - #42854

Closed
Ashraf Ali (ashrafiucse) wants to merge 1 commit into
microsoft:mainfrom
ashrafiucse:fix-42850
Closed

Ashraf Ali (ashrafiucse) wants to merge 1 commit into
microsoft:mainfrom
ashrafiucse:fix-42850

Conversation

@ashrafiucse

Copy link
Copy Markdown
Contributor

Summary

  • HighlightController was resolving every entry from the main frame, so frame.locator(...).highlight() highlighted elements in the wrong frame (1.63 regression from chore(highlight): resolve highlights periodically in HighlightController #42277)
  • Thread the originating frame through the highlight entry and resolve relative to it; key entries by frame as well, so the same selector can be highlighted from different frames
  • Regression tests: frame-relative highlight, same selector across frames, highlight surviving frame navigation

Fixes #42850

@ashrafiucse

Copy link
Copy Markdown
Contributor Author

Closing since #42868 landed the same fix. Two scenarios I had covered here that aren't on main: highlighting the same selector from different frames, and highlights surviving frame navigation — happy to send them as a follow-up if useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: 1.63 regression - page.frame(...).locator(...).highlight highlights elements in the wrong frame

1 participant