Add NAV 246904 mileage rounding dataset task - #899
Closed
alexei-dobriansky wants to merge 3 commits into
Closed
alexei-dobriansky wants to merge 3 commits into
alexei-dobriansky wants to merge 3 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d824ab77-41d6-4cfc-9445-9204d1d08988
This was referenced Sep 25, 2026
alexei-dobriansky
added this pull request to stack #904
September 25, 2026 15:23
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d824ab77-41d6-4cfc-9445-9204d1d08988
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d824ab77-41d6-4cfc-9445-9204d1d08988
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The changes are consistent and the referenced end-to-end run successfully validated the new task.
Review effort: Balanced
Findings: None
What changed in this PR
Adds the NAV 246904 mileage-rounding benchmark task and supporting BC 29/30 artifact infrastructure.
Changes:
- Adds the dataset entry and screenshot-free reproduction instructions.
- Pins insider artifacts and extends NAV sparse checkout.
- Tests artifact selection and internal-app coverage.
| File | Description |
|---|---|
dataset/bcbench.jsonl |
Adds the validated mileage-rounding task. |
dataset/problemstatement/microsoftInternal__NAV-246904/README.md |
Documents reproduction and expected behavior. |
scripts/BCBenchUtils.psm1 |
Adds insider pins and internal-app checkout. |
scripts/Download-BCSymbols.ps1 |
Uses centralized artifact configuration. |
tests/test_artifact_config.py |
Tests artifact pins and checkout coverage. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
|
Let's skip this one due to the need for Internal apps. One more thing to point out is, we probably want to keep the bug description the same as before, if that didn't have enough context, we skip them |
alexei-dobriansky
removed this pull request from stack #904
September 29, 2026 20:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
Summary
microsoftInternal__NAV-246904[AI-REPRO]from work item 634224App/Internal/Appsin NAV sparse checkoutCandidate criteria
Validation
python -m uv run pytest tests\test_artifact_config.py tests\test_dataset_integrity.pypython -m uv run pre-commit run --all-files