Repository navigation
Add BCApps 7070 subscription customer dataset task - #900
alexei-dobriansky wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The entry matches the upstream change and its dedicated build-and-test validation job passed.
Review effort: Balanced
Findings: None
What changed in this PR
Adds a validated BCApps Subscription Billing bug-fix task for changing customers on contracts with closed subscription lines.
Changes:
- Adds a text-only reproduction and expected behavior.
- Registers the upstream patch, regression test, and BC 29 setup metadata.
- References an end-to-end validation run that completed successfully.
| File | Description |
|---|---|
dataset/problemstatement/microsoft__BCApps-7070/README.md |
Defines the customer-change reproduction scenario. |
dataset/bcbench.jsonl |
Registers the BCApps 7070 benchmark entry. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sun Haoran (haoranpb)
left a comment
There was a problem hiding this comment.
This is a good addition!
Let's align the problem statement to the original state
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d824ab77-41d6-4cfc-9445-9204d1d08988
8fe7224 to
93740e5
Compare
Sun Haoran (haoranpb)
left a comment
There was a problem hiding this comment.
I think the rebase went wrong..?
I see this commit is rebased away: 8fe7224 , which is fine, I can make a change after your PRs are meged.
| Url = 'https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_git/NAV' | ||
| Token = $env:ADO_TOKEN | ||
| SparseCheckoutPaths = @('App/Apps', 'App/Layers') | ||
| SparseCheckoutPaths = @('App/Apps', 'App/Internal/Apps', 'App/Layers') |
There was a problem hiding this comment.
The rebase went wrong?
| [hashtable] $pinnedInsiderUrls = @{ | ||
| '29.0' = 'https://bcinsider-fvh2ekdjecfjd6gk.b02.azurefd.net/sandbox/29.0.54011.55007/w1' | ||
| '30.0' = 'https://bcinsider-fvh2ekdjecfjd6gk.b02.azurefd.net/sandbox/30.0.55015.0/w1' | ||
| } |
There was a problem hiding this comment.
Oops, my PR went in first, this is now changed to a json file
Stack
Summary
microsoft__BCApps-7070Validation