Skip to content

Add BCApps 7070 subscription customer dataset task - #900

Open
alexei-dobriansky wants to merge 1 commit into
mainfrom
dataset/stack-02-bcapps-7070
Open

alexei-dobriansky wants to merge 1 commit into
mainfrom
dataset/stack-02-bcapps-7070

Conversation

@alexei-dobriansky

@alexei-dobriansky alexei-dobriansky commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Stack

  1. BCApps 7070 customer change (this PR)
  2. Add BCApps 10345 service contract dataset task #901 — BCApps 10345 service-contract invoicing
  3. Add BCApps 10808 exchange rate dataset task #902 — BCApps 10808 exchange-rate adjustment
  4. Add BCApps 11274 drop shipment dataset task #903 — BCApps 11274 drop-shipment reversal and version bump

Summary

  • add microsoft__BCApps-7070
  • align the problem statement with the original GitHub issue
  • include shared pinned BC 29/30 artifact configuration and artifact regression tests

Validation

  • artifact and dataset integrity tests pass
  • previously passed end-to-end in run 35894324791

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The entry matches the upstream change and its dedicated build-and-test validation job passed.

Review effort: Balanced
Findings: None

What changed in this PR

Adds a validated BCApps Subscription Billing bug-fix task for changing customers on contracts with closed subscription lines.

Changes:

  • Adds a text-only reproduction and expected behavior.
  • Registers the upstream patch, regression test, and BC 29 setup metadata.
  • References an end-to-end validation run that completed successfully.
File Description
dataset/​problemstatement/​microsoft__BCApps-7070/​README.md Defines the customer-change reproduction scenario.
dataset/​bcbench.jsonl Registers the BCApps 7070 benchmark entry.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@haoranpb Sun Haoran (haoranpb) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good addition!

Let's align the problem statement to the original state

Comment thread dataset/problemstatement/microsoft__BCApps-7070/README.md
Comment thread dataset/bcbench.jsonl
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: d824ab77-41d6-4cfc-9445-9204d1d08988
@alexei-dobriansky
alexei-dobriansky force-pushed the dataset/stack-02-bcapps-7070 branch from 8fe7224 to 93740e5 Compare September 29, 2026 20:11
@alexei-dobriansky
alexei-dobriansky removed this pull request from stack #904 September 29, 2026 20:13
@alexei-dobriansky
alexei-dobriansky changed the base branch from dataset/stack-01-nav-246904 to main September 29, 2026 20:13
@alexei-dobriansky
alexei-dobriansky added this pull request to stack #906 September 29, 2026 20:14

@haoranpb Sun Haoran (haoranpb) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the rebase went wrong..?

I see this commit is rebased away: 8fe7224 , which is fine, I can make a change after your PRs are meged.

Comment thread scripts/BCBenchUtils.psm1
Url = 'https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_git/NAV'
Token = $env:ADO_TOKEN
SparseCheckoutPaths = @('App/Apps', 'App/Layers')
SparseCheckoutPaths = @('App/Apps', 'App/Internal/Apps', 'App/Layers')

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rebase went wrong?

Comment thread scripts/BCBenchUtils.psm1
Comment on lines +547 to +550
[hashtable] $pinnedInsiderUrls = @{
'29.0' = 'https://bcinsider-fvh2ekdjecfjd6gk.b02.azurefd.net/sandbox/29.0.54011.55007/w1'
'30.0' = 'https://bcinsider-fvh2ekdjecfjd6gk.b02.azurefd.net/sandbox/30.0.55015.0/w1'
}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, my PR went in first, this is now changed to a json file

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants