Repository navigation
Add five validated bug-fix dataset entries - #891
alexei-dobriansky wants to merge 7 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d824ab77-41d6-4cfc-9445-9204d1d08988
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d824ab77-41d6-4cfc-9445-9204d1d08988
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d824ab77-41d6-4cfc-9445-9204d1d08988
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d824ab77-41d6-4cfc-9445-9204d1d08988
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d824ab77-41d6-4cfc-9445-9204d1d08988
There was a problem hiding this comment.
Note
Copilot was unable to run its full agentic suite in this review.
Copilot review overview
Review effort: Lite
Findings: None
What changed in this PR
This PR updates how Business Central artifact URLs are resolved so that insider versions use the insider artifact feed, and expands repo sparse-checkout paths to include internal apps while adding new dataset problem statements and bumping the package version.
Changes:
- Pass resolved BC version into
Get-BCBenchArtifactConfigand add version-based insider-feed selection logic. - Improve robustness by throwing when
Get-BCArtifactUrlfails to resolve an URL. - Add new dataset problem statements and bump project version to
0.14.0.
| File | Description |
|---|---|
tests/test_artifact_config.py |
Adds regression tests validating artifact-config resolution and workflow wiring. |
scripts/Setup-ContainerAndRepository.ps1 |
Passes version into artifact-config and errors clearly when URL resolution fails. |
scripts/Download-BCSymbols.ps1 |
Aligns symbol download artifact selection with category/version config. |
scripts/BCBenchUtils.psm1 |
Extends sparse-checkout paths and adds -Version support + logic to Get-BCBenchArtifactConfig. |
pyproject.toml |
Bumps package version to 0.14.0. |
.github/actions/setup-bc-container-repo/action.yml |
Passes resolved version into artifact-config inside the action. |
dataset/problemstatement/**/README.md |
Adds new problem statements for additional dataset instances. |
dataset/bcbench.jsonl |
Appends new dataset instances and patches. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d824ab77-41d6-4cfc-9445-9204d1d08988
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d824ab77-41d6-4cfc-9445-9204d1d08988
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
BC 30 setup currently fails, and 20 additional unvalidated entries contradict the documented five-entry scope.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Sun Haoran (haoranpb)
left a comment
There was a problem hiding this comment.
There are more than 5 tasks added, did we make a mistake?
Maybe consider splitting one task per PR, so it's easier to review and merge
Most importantly, have you manually reviewed each task? We have to make sure they each contain enough context for them to be resolved, for example, not in the attachment that are not captured here
|
Addressed the review feedback by replacing this monolithic PR with a five-PR stack:
Changes made in the replacement stack:
ADO
Cumulative validation is running on the top stack branch: https://github.com/microsoft/BC-Bench/actions/runs/36153236382 Closing this PR as superseded by the stack above. |


Summary
This PR adds five new bug-fix tasks that passed the complete BC-Bench execution workflow, along with their problem statements and screenshots.
It also updates environment setup so BC 29+ bug-fix and test-generation entries use insider artifacts, and NAV sparse checkouts include internal application projects.
The benchmark version is bumped from
0.13.0to0.14.0because dataset changes affect evaluation results.Added entries
microsoft__BCApps-7070— customer cannot be changed when closed subscription lines existmicrosoft__BCApps-10345— service-contract invoicing state is not reset after deleting an invoicemicrosoft__BCApps-10808— exchange-rate adjustment amount is calculated incorrectlymicrosoft__BCApps-11274— drop-shipment reversal fails at bin-mandatory locationsmicrosoftInternal__NAV-246904— mileage expense posting fails because of inconsistent roundingCandidate selection criteria
Candidates were discovered from merged BCApps and internal NAV pull requests and were retained only when they met the following structural criteria:
mainormaster);[Test]procedures;Execution verification
Static screening was followed by full execution validation. For an entry to remain in this PR, BC-Bench had to prove that:
A larger initial candidate set was removed after this stage when tests already passed before the fix, still failed afterward, or historical source could not be built and published against currently available artifact snapshots.
Final successful validation: Dataset Validation and Verification run 35894324791.
Environment setup changes
bcinsiderartifacts.App/Internal/Appsfor internal application tasks.ArtifactUrlbinding error.Validation
python -m uv run pytest tests\test_artifact_config.py tests\test_dataset_integrity.py tests\test_collect_gh.pypython -m uv run pre-commit run --all-filespython -m uv lock --check