Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a99f53749b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const composeProjectId = mostRecentImportedProjectId(imported); | ||
| if (composeProjectId !== null) setRootComposeProjectId(composeProjectId); |
There was a problem hiding this comment.
If the user clicks “Skip setup” or navigates back to a completed step while project creation is still pending, ProjectsStepContainer unmounts, but this asynchronous setter still runs when the imports finish. Because it writes the global root-compose atom, it can unexpectedly replace a project the user selected after leaving setup; primaryBusy disables only the import button, not those navigation controls. Guard this write against an obsolete/unmounted import or prevent leaving while it is pending.
Useful? React with 👍 / 👎.
| if (process.env.CLAUDE_CODE_OAUTH_TOKEN?.trim()) { | ||
| return healthResult("ready", { installedVersion: version }); |
There was a problem hiding this comment.
On a machine authenticated exclusively with CLAUDE_CODE_OAUTH_TOKEN and no saved credential file or Keychain entry, this now reports provider health as ready, but getClaudeProviderUsage() still reads only readCredentials() and returns unauthenticated. Consequently the Usage UI tells a working token-authenticated user to sign in and cannot fetch limits; the environment token needs to be used consistently by the usage path as well.
Useful? React with 👍 / 👎.
brsbl
changed the title
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This is an automated message. We have closed this pull request because it has been open for more than two weeks. |
Human comments
What was wrong
An installed but signed-out agent offered no recovery before submitting. Reused workspaces skipped provider health reads because their project host was absent.
What changed
Supersedes #5317. Project selection has moved to #5415, independently based on main. This PR remains held for the user's sign-in behavior decision.
How you verified
9a6db07c11cfa91a8f71643739653a21048fa17d.The project-selection code is removed; setup replay supplies its telemetry entry after integrating main. Screenshots below are prior evidence from #5317: before
7af427b8e457c69069631adf27feebbbe2bfa0cd, after7dbb618b424b85ba95c392a7c3665bd5f3117d8b. Full viewport captures use 1440 × 900 or 390 × 844 CSS pixels at 2×. These are not a new sign-off request.Known P2 follow-up: idle composer health polling.
BB-Thread-ID: thr_gt5eeahuym
BB-Thread: Onboarding