Skip to content

Preselect the imported project and show signed-out agents in the composer - #5317

Closed
brsbl wants to merge 34 commits into
bb/shared-onboarding-components-thr_gt5eeahuymfrom
bb/composer-first-thread-thr_7xet9fqq42
Closed

brsbl wants to merge 34 commits into
bb/shared-onboarding-components-thr_gt5eeahuymfrom
bb/composer-first-thread-thr_7xet9fqq42

Conversation

@brsbl

@brsbl brsbl commented Oct 10, 2026 •

Copy link
Copy Markdown
Collaborator

Human comments

What was wrong

After importing a project in setup, the home composer still showed “No project”. An installed but signed-out agent offered no recovery before submitting. Reused workspaces also skipped provider health reads because their project host was absent.

What changed

Select the most recently active project from the completed import. For a signed-out or expired agent, name the problem in the composer and replace submit with Sign in, opening the existing Agent step without losing the draft or resetting setup completion. Resolve reused-workspace health through its environment and offer sign-in on the primary machine. Preserve supported Claude token authentication.

How you verified

Full remote CI passed at 7dbb618b424b85ba95c392a7c3665bd5f3117d8b. Cumulative review's validated P1s are fixed; no unresolved P0/P1. The token-only Claude regression failed remotely before the fix and passes in final CI.

QA PASS in Chrome for Testing 154.0.8037.92 through BB Browser Automation, isolated branch web app. The bounded pass covered signed-out Enter blocking, Sign in → Agent step → close with draft and completion preference preserved, project import/preselection and reload, and a successful offline Echo thread submission. It found the reused-workspace health gap; after the targeted fix and green CI, exact-head QA verified environment-scoped health requests, Sign in, zero premature thread submissions, and draft preservation. Final-head screenshot refresh also verified project import and phone persistence. No observed page errors. External provider login was not performed.

Before: parent 7af427b8e457c69069631adf27feebbbe2bfa0cd. After: final head above. Same isolated fixture, routes and interaction states at 1440 × 900 or 390 × 844 CSS pixels, full viewport at 2×. Codex is installed with an empty task CODEX_HOME; the fixed draft is “Walk me through this project.” Import rows follow importing only loop-machine through the real guide. The guide row compares the absent prior action with the newly reachable state.

Screen / state Before After
Signed out · desktop Before: Signed out · desktop After: Signed out · desktop
Signed out · dark Before: Signed out · dark After: Signed out · dark
Draft after closing sign-in · desktop Before: Draft after closing sign-in · desktop After: Draft after closing sign-in · desktop
Draft · phone Before: Draft · phone After: Draft · phone
Open sign-in guide · desktop Before: Open sign-in guide · desktop After: Open sign-in guide · desktop
Imported project · desktop Before: Imported project · desktop After: Imported project · desktop
Imported project · phone Before: Imported project · phone After: Imported project · phone
Reused workspace · desktop Before: Reused workspace · desktop After: Reused workspace · desktop

Known P2 follow-ups: closing setup during a pending import can allow later preselection; idle composer health polling. User screenshot sign-off is pending.

BB-Thread-ID: thr_7xet9fqq42

BB-Thread: Notification card, setup-guide events, setupComplete

AGENT GENERATED

brsbl and others added 15 commits October 8, 2026 11:59
… record onboarding events

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rmission is decided

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…r follows

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…the composer

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…separately

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-notification-opt-in-onboardin-thr_7xet9fqq42

# Conflicts:
#	apps/app/src/components/onboarding/Onboarding.stories.tsx
#	apps/app/src/components/onboarding/SetupChecklistHost.tsx
#	apps/app/src/components/onboarding/SetupChecklistViews.tsx
#	packages/domain/src/plugin-sdk-version.ts
#	packages/plugin-sdk/package.json
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…te badge

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…can't re-show it

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…extra, and expose setupComplete

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-notification-opt-in-onboardin-thr_7xet9fqq42

# Conflicts:
#	apps/app/src/components/onboarding/Onboarding.stories.tsx
#	apps/app/src/components/onboarding/OnboardingGate.tsx
#	apps/app/src/components/onboarding/SetupChecklistHost.test.tsx
#	apps/app/src/components/onboarding/SetupChecklistHost.tsx
#	apps/app/src/components/plugin/PluginNewThreadComposer.test.tsx
#	apps/app/src/views/RootComposeView.tsx
#	packages/domain/src/plugin-sdk-version.ts
#	packages/plugin-sdk/package.json
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…es hierarchy, one done treatment, new plugin list

- Agent step names the checked machine when it isn't this computer; new ACP footer line
- Projects: new repos first with a quiet selection header, already-added repos as a checked group, subtitle matches the 7-day preselection
- Devices: mobile app as the primary card with one Get the app action, browser access and another machine as secondary rows, footer button Start your first thread
- Plugins: Workflows, Browser Automation, Agent Annotations, GitHub, Ask User Question, File Editor with first-session descriptions
- Shared done mark (diff-added green) for header steps, ready agents, connect On and added repos; Agent step label is Agents
- Notification card copy; step_reached counts once per step and leaving the Devices route counts as skipped

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s in the home composer

After the setup guide imports projects, the home composer now selects the
imported project whose repo was active most recently instead of No project.

The home composer now shows a banner when the selected agent is signed out
or its session expired on the selected machine, with a Sign in button that
reopens the setup guide's agent step. Sending stays enabled.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@brsbl
brsbl requested a review from SawyerHood October 10, 2026 02:51
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

brsbl and others added 3 commits October 9, 2026 19:59
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e room

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… cards

The placeholder names the problem and the submit button becomes Sign in,
replacing the separate banner. SuggestionCard and InlineConfirmation live in
shared-ui so core and the bundled Tips and What's new plugins share one look.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@brsbl brsbl changed the title Preselect the imported project and warn about a signed-out agent in the home composer Preselect the imported project, show a signed-out agent in the composer, and add shared suggestion cards Oct 10, 2026
brsbl and others added 3 commits October 10, 2026 00:10
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…on-opt-in-onboardin-thr_7xet9fqq42' into bb/composer-first-thread-thr_7xet9fqq42
@brsbl
brsbl changed the base branch from main to bb/checklist-led-home-notification-opt-in-onboardin-thr_7xet9fqq42 October 10, 2026 07:17
brsbl and others added 5 commits October 10, 2026 06:51
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…udge to the plugin registry

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…on-opt-in-onboardin-thr_7xet9fqq42' into bb/composer-first-thread-thr_7xet9fqq42
@brsbl brsbl changed the title Preselect the imported project, show a signed-out agent in the composer, and add shared suggestion cards Preselect the imported project and show signed-out agents in the composer Oct 12, 2026
@brsbl
brsbl changed the base branch from bb/checklist-led-home-notification-opt-in-onboardin-thr_7xet9fqq42 to bb/shared-onboarding-components-thr_gt5eeahuym October 12, 2026 21:24
@brsbl

brsbl commented Oct 12, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded by #5413, independently based on main. The complete feature diff is byte-for-byte identical; review, QA results and screenshots are retained. No history was rewritten.

@brsbl brsbl closed this Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant