Skip to content

Select the last imported project during first-run setup - #5415

Merged
brsbl merged 3 commits into
mainfrom
bb/remember-imported-project-thr_gt5eeahuym
Oct 13, 2026
Merged

brsbl merged 3 commits into
mainfrom
bb/remember-imported-project-thr_gt5eeahuym

Conversation

@brsbl

@brsbl brsbl commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Human comments

What was wrong

The first-run guide imported projects without selecting one for the first thread, leaving the composer on No project.

What changed

  • Select the last successfully imported project during first-run setup.
  • Preserve an explicit project choice or draft, including one made while importing.
  • Leave the composer selection alone when replaying or closing the guide.

How you verified

  • Remote CI passed at 6647f729. Run
  • Chrome for Testing 154.0.8037.92: zero, one and several first-run imports passed at desktop and mobile widths.
  • Explicit choice, draft preservation, replay, delayed closure, partial-failure retry and hard reload passed on the same head.

Before and after

Before: e9dafb6c0245a37c6972dffa71134d546f3d497e · After: 6647f7294b82cc987e288f8f68073c73e34c196e · Full viewport, 2×.

Screen / state Viewport Before After
Zero imports Desktop · 1440×900 Before: Zero imports After: Zero imports
Zero imports Mobile · 390×844 Before: Zero imports After: Zero imports
One imported project Desktop · 1440×900 Before: One imported project After: One imported project
One imported project Mobile · 390×844 Before: One imported project After: One imported project
Several imported projects Desktop · 1440×900 Before: Several imported projects After: Several imported projects
Several imported projects Mobile · 390×844 Before: Several imported projects After: Several imported projects

BB-Thread-ID: thr_gt5eeahuym

BB-Thread: Onboarding

AGENT GENERATED

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T02:53:12.355293Z c34bd90 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c34bd90ae1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

const projectId = isProjectlessProjectId(requestedCandidate)
? PERSONAL_PROJECT_ID
: requestedCandidate;
const projectUnavailable = sidebarNavigationSettled && !candidateKnown;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Allow switching away from deleted projects with attachments

When the retained project is unavailable and the saved draft contains an uploaded attachment, selecting another project still attempts to copy the attachment with the deleted projectId as its source. The copy endpoint rejects this because apps/server/src/routes/projects.ts:960-964 requires the source project to exist, and changeProject then returns "refused"; consequently, the user cannot choose the required destination without first removing every attachment from the draft. Handle the unavailable-source case when preserving this ID so recovery remains possible.

Useful? React with 👍 / 👎.

@brsbl brsbl changed the title Select imported projects and remember the last-used project Select the last imported project during first-run setup Oct 13, 2026
@brsbl
brsbl merged commit 782353f into main Oct 13, 2026
28 checks passed
@brsbl
brsbl deleted the bb/remember-imported-project-thr_gt5eeahuym branch October 13, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant