This repository was archived by the owner on Sep 10, 2026. It is now read-only.
Repository navigation
Scaffold an optional AUTH_DOMAIN - #56
Merged
Merged
Conversation
Web sign-in runs through Firebase's popup, which loads `https://<authDomain>/__/auth/handler`, so Google's account chooser reads "Sign in to continue to my-project.firebaseapp.com". `app-config.json` now carries an `AUTH_DOMAIN` key and the generated `main.dart` passes it to `EngineConfig.authDomain`. Empty is the scaffolded value and the right answer for almost every game: it leaves sign-in on the Firebase project's own domain, which works everywhere and needs no Firebase Hosting. Setting it is cosmetic and web-only, and the value is not APP_HOST: it must be a Firebase Hosting domain, a sibling of the Worker's host rather than the host itself. Raises the eigen_flutter floor to ^0.4.1 for that parameter. Additive, so a patch pre-1.0, but ^0.4.0 also still resolves 0.4.0, where the parameter does not exist and the scaffold would not compile. Needs eigen_flutter 0.4.1 published first. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to eigen-flutter#34.
Web sign-in runs through Firebase's popup, which loads
https://<authDomain>/__/auth/handler, so Google's account chooser reads "Sign in to continue to my-project.firebaseapp.com".app-config.jsonnow carries anAUTH_DOMAINkey and the generatedmain.dartpasses it toEngineConfig.authDomain.Empty is the scaffolded value and the right answer for almost every game. It leaves sign-in on the Firebase project's own domain, which works everywhere and needs no Firebase Hosting. Setting it is cosmetic and web-only; Android never shows the string.
The generated
main.dartcarries a comment saying exactly that, because the trap is assuming it isAPP_HOST. It is not: the value must be a domain Firebase Hosting answers for, a sibling of the Worker's host rather than the host itself.Merge order
The pinned
eigen_flutterfloor moves to^0.4.1.authDomainis additive, so a patch pre-1.0, but^0.4.0also still resolves 0.4.0, where the parameter does not exist and a scaffold would not compile. The floor is what keeps the generated code and the installed shell in agreement.eigen_flutter0.4.1 must be published before this releases. Otherwiseflutter pub add eigen_flutter@^0.4.1fails outright during scaffolding.Verification
80 scaffolder tests pass. Scaffolded a project end to end and confirmed the emitted
app/app-config.jsoncarriesAUTH_DOMAINalongside the existing keys.🤖 Generated with Claude Code