This repository was archived by the owner on Sep 10, 2026. It is now read-only.
Repository navigation
Fix the version dropdown, and document icons, Analytics and the sign-in host - #42
Merged
Merged
Conversation
…in host Four unrelated reports, all implementor-facing. The version dropdown pinned `reference/compatibility` in via `dropdownItemsAfter`. Each version entry links to the doc you are currently reading, so on that doc's own page the two entries collide: identical hrefs, both marked active. Docusaurus' own example pins `/versions`, a page outside `/docs` that no version owns, which is the case the option is for. Compatibility stays in `referenceSidebar`. `dropdownActiveClassDisabled` follows, because the entry is a self-link on every docs page and so permanently "active", which says nothing when there is one version. Branding now separates the icon question from the web build, matching the engine: the placeholder is served until a game has icons of its own, and a game with no web build gets its own icons by copying them into `public/`. Firebase setup no longer implies the console and CLI create flows are equivalent. Only the console links a Google Analytics account, so a CLI-created project reports "Google Analytics not enabled for Project" and the engine's automatic events have nowhere to land. Deploying the web app gains the sign-in host: what the firebaseapp.com string is, why leaving it alone is fine, and the two independent changes if you want your own name there. `AUTH_DOMAIN` is not `APP_HOST`, and the consent screen needs no domain at all. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four unrelated reports, all implementor-facing.
1. The version dropdown
dropdownItemsAfterpinnedreference/compatibilityinto the version dropdown. Each version entry links to the doc you are currently reading, so on the compatibility page itself the two entries collided. From the built HTML before this change:Identical hrefs, both active. Docusaurus' own example pins
/versions, a page outside/docsthat no version owns — that is the case the option is for. Compatibility is already inreferenceSidebar, so nothing becomes unreachable.dropdownActiveClassDisabled: truefollows, because the entry is a self-link on every docs page and therefore permanently active, which says nothing when there is one version. After, on bothcompatibilityandintro:2. Icons (branding)
Separates the icon question from the web build, matching eigen-server#55: the engine serves a placeholder until a game has icons of its own, and a game with no web build now gets its own icons by copying them into
public/.3. Google Analytics
configure.mdimplied the console and CLI project-create flows were equivalent ("with Analytics enabled, or let step 2 do it"). Only the console links an Analytics account, so a CLI-created project reports "Google Analytics not enabled for Project" and the engine's automaticscreen_viewand seven events have nowhere to land. Corrected there, plus a new quickstart step naming the banner and the fix.4. The sign-in host
New section in Deploy the web app: what the
firebaseapp.comstring is, why leaving it alone is fine, and the two independent changes if you want your own name there — the OAuth consent screen (no domain needed) andAUTH_DOMAIN(Firebase Hosting domain needed). Stresses thatAUTH_DOMAINis notAPP_HOST. Reference tables inconfigure.mdandmanual-setup.mdupdated.Merge order
This should land after the engine and scaffolder are published (eigen-server#55, eigen-server#56, eigen-flutter#34). The site is the source of truth and deploys on merge, so it should not describe an
AUTH_DOMAINor a placeholder icon nobody can install yet. The dropdown fix is independent and only waits for the same reason.Verification
pnpm buildclean withonBrokenLinks: "throw", pluscheck-admonitions,check-docs-versionandtypecheck. Dropdown markup verified in built output, not by inspection.🤖 Generated with Claude Code