Repository navigation
feat(setup): add mentoring family first-run welcome guide - #1708
Conversation
|
Hi @potiuk, I've implemented the Mentoring family welcome guide for #1659, following the established pattern from #1669. It covers all four mentoring skills, their configuration requirements, example workflows, and maintainer confirmation boundaries. I've also added the README link, first-run evaluation fixture, and regression tests. All repository-wide checks passed locally with |
Kaap10
left a comment
There was a problem hiding this comment.
Thanks @KatalKavya96 for adding the mentoring family welcome guide!
Tested locally — the guide rendering looks clean, test_welcome.py passes all 51 tests across all four mentoring skills, render-preflight-fixtures.py --check passes with zero drift, and the case counts in the evals READMEs are updated consistently.
Left one inline suggestion on docs/mentoring/README.md regarding layout consistency with other family READMEs (security, utilities, contributor-growth). Other than that, everything looks solid!
…ate" The mentoring welcome guide said existing welcomes and handled threads "are skipped as appropriate", which leaves a newcomer guessing what is skipped. Name it outright, and re-render the case-11 fixture that embeds the guide. Generated-by: Claude Opus 5
potiuk
left a comment
There was a problem hiding this comment.
Adds the mentoring-family first-run welcome guide in the same shape as the utilities and security guides, with matching tests, a preflight-floor eval case and the README pointer; the content checks out against the four mentoring skills and their config files.
I pushed one small fixup commit (aea0177) rather than leave a nit for another round trip: the guide said existing welcomes and handled threads "are skipped as appropriate", which leaves a newcomer guessing what actually gets skipped. It now reads "Contributors who were already welcomed, and threads already handled, are skipped.", and the case-11-mentoring-first-run report that embeds the guide is re-rendered to match. Thanks for the guide!
This review was drafted by an AI-assisted tool and
confirmed by an Apache Magpie maintainer. The maintainer
approving this PR has read the findings and signed off. If
something feels off, please reply on the PR and a maintainer
will follow up.More on how Apache Magpie handles maintainer review:
Contributing guide.
Summary
welcome,good-first-issue-sweep,good-first-issue-author, andnewcomer-issue-explainer, helping maintainers discover the available workflows and get started through natural-language requests.Type of change
.claude/skills/<name>/) — eval fixtures updated belowtools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md)projects/_template/)prek, workflows, validators)Test plan
prek run --all-filespassesuv run pytest/ruff check/mypypasses(
PYTHONPATH=tools/skill-evals/src python3 -m skill_evals.runner tools/skill-evals/evals/<skill>/)(a regression test for the bug fixed / the behaviour added — see CONTRIBUTING.md)
render-preflight-fixtures.py --check.git diff --checkpassed.prek.RFC-AI-0004 compliance
Linked issues
Closes #1659
Refs #1654
Notes for reviewers (optional)
welcomewith its actual surface hash,sha256:a61c6575d69da08a.AI assistance disclosure: AI assistance was used for repository analysis, implementation drafting, and review. Changes were applied and validated locally by the contributor.