Repository navigation
feat(setup): add pairing family first-run welcome guide - #1706
Conversation
|
Hi @potiuk, I've implemented the Pairing family welcome guide for #1661, following the established pattern from #1653 and the merged #1669. I've included both pairing skills, the README link, first-run evaluation fixture, and regression tests. All repository-wide checks passed locally with Thanks! |
Kaap10
left a comment
There was a problem hiding this comment.
Thanks @KatalKavya96 for putting this together!
Tested locally — the welcome guide content is crisp, the surface hash matches self-review accurately, and both regression tests and preflight fixture checks pass cleanly.
Left one inline suggestion on docs/pairing/README.md regarding layout consistency with other family READMEs (security, utilities, contributor-growth). Other than that, everything looks solid!
…ig bullet `/magpie-setup:setup config` configures the installed skills for the user; it installs nothing, so the guide now says "Configure it for yourself". The "Adversarial reviewers" bullet pointed at `adversarial-review.md`, which neither pairing skill reads, and called the passes "three independent review passes", which holds only for multi-agent-review, so it is dropped. The case-11 fixture that embeds the guide is re-rendered. Generated-by: Claude Opus 5
…706-fixup Generated-by: Claude Opus 5 # Conflicts: # tools/setup-preflight/tests/test_welcome.py # tools/skill-evals/evals/setup/README.md # tools/skill-evals/evals/setup/preflight-floor/fixtures/case-9-first-magpie-run/report.md
potiuk
left a comment
There was a problem hiding this comment.
Adds the pairing-family first-run welcome guide for self-review and multi-agent-review, matching the utilities guide file for file; the scope options it lists exist in both skills and the fixture's self-review surface hash is correct.
I pushed two commits rather than send this round again:
- d788b60 — wording. "Install for yourself with
/magpie-setup:setup config" now reads "Configure it for yourself …":configconfigures the skills you already installed and installs nothing. I also dropped the "Adversarial reviewers" bullet: neither pairing skill readsadversarial-review.md, and "three independent review passes" holds only formulti-agent-review(self-reviewis a single pass), so it would have pointed newcomers at a file this family never uses. - 2c1c66f — merge of
main. #1708 (the mentoring guide) landed first and claimed the same slots, so the pairing fixture moves tocase-12-pairing-first-run, the setup case counts go to 132, the test lists carry both families, and thecase-9report is re-rendered with both guides in its "More guides" list.
Thanks for the guide!
This review was drafted by an AI-assisted tool and
confirmed by an Apache Magpie maintainer. The maintainer
approving this PR has read the findings and signed off. If
something feels off, please reply on the PR and a maintainer
will follow up.More on how Apache Magpie handles maintainer review:
Contributing guide.
Summary
pairingfamily, coveringself-reviewandmulti-agent-review, so newcomers can understand the review workflow and get started with plain-language requests.docs/pairing/README.md.self-reviewsurface hash. Regenerate the general welcome report and update evaluation case counts.Type of change
.claude/skills/<name>/) — eval fixtures updated belowtools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md)projects/_template/)prek, workflows, validators)Test plan
prek run --all-filespassesuv run pytest/ruff check/mypypasses(
PYTHONPATH=tools/skill-evals/src python3 -m skill_evals.runner tools/skill-evals/evals/<skill>/)(a regression test for the bug fixed / the behaviour added — see CONTRIBUTING.md)
pytest tests/test_welcome.py— 51 tests passed before the additional family assertion.render-preflight-fixtures.py --check— passed.git diff --cached --check— passed.prek.RFC-AI-0004 compliance
<PROJECT>,<tracker>,<upstream>,<security-list>) used in all skill / tool prose (thecheck-placeholdersprek hook is the mechanical gate)No runtime behavior, external write permissions, or security controls are changed. Both pairing skills remain read-only.
Linked issues
Closes #1661
Refs #1654
Notes for reviewers (optional)
sections/welcome.mdrules and generated footer; no additional per-family rules section or production logic changes are needed.self-reviewwithsurface_hash: sha256:ea0a2e29bb2aa0e0.AI tooling disclosure: AI assistance was used for repository analysis, patch drafting, and review. Changes were applied and validated locally by the contributor.