Repository navigation
feat(setup): add issue family first-run welcome guide - #1709
Conversation
|
Hi @potiuk, I've implemented the Issue Management family welcome guide for #1656, following the established approach from #1669. It covers all eight skills, their configuration requirements, example workflows, and confirmation boundaries. I've also included the README integration, first-run evaluation fixture, and regression tests, including coverage for the triage skill naming collision between the Issue and Security families. All repository-wide checks passed locally with prek run --all-files. Thanks! |
The issue welcome guide said a bug is reproduced "then reassessed" for its evidence, but `reassess` sweeps resolved or end-of-life issues against today's code; it gets its own step now. Two sentences sharing one line are split (semantic line breaks), and the issue-management README points at the guide with the same block the other family READMEs use, which also says how to bring it back. The case-11 fixture that embeds the guide is re-rendered. Generated-by: Claude Opus 5
…709-fixup Generated-by: Claude Opus 5 # Conflicts: # tools/setup-preflight/tests/test_welcome.py # tools/skill-evals/README.md # tools/skill-evals/evals/setup/README.md # tools/skill-evals/evals/setup/preflight-floor/fixtures/case-9-first-magpie-run/report.md
potiuk
left a comment
There was a problem hiding this comment.
Adds the issue-family first-run welcome guide covering all eight issue skills, with a careful test that magpie-issue-triage resolves to the issue family while bare issue-triage stays security; the fixture's triage surface hash is correct and each config file it names matches the skill's requires_config.
I pushed two commits rather than send this round again:
- 92f5bc7 — wording. Step 3 read "Reproduce a bug, then reassess its evidence", but
reassesssweeps resolved or end-of-life issues against today's code, so it is now its own step ("re-assess old issues"). Two sentences that shared a line are split (semantic line breaks), anddocs/issue-management/README.mdnow points at the guide with the same block the other family READMEs use, which also tells the reader how to bring it back. - e37a9a8 — merge of
main. The mentoring (#1708) and pairing (#1706) guides landed first and claimed the same slots, so this fixture moves tocase-13-issue-first-run, the setup case counts go to 133, the test lists carry all three families, and thecase-9report is re-rendered.
The earlier red check was a cancelled CodeQL run, not a failure; the push re-runs it. Thanks for the guide!
This review was drafted by an AI-assisted tool and
confirmed by an Apache Magpie maintainer. The maintainer
approving this PR has read the findings and signed off. If
something feels off, please reply on the PR and a maintainer
will follow up.More on how Apache Magpie handles maintainer review:
Contributing guide.
Summary
docs/issue-management/README.md, add first-run regression tests and a preflight-floor evaluation fixture, regenerate affected welcome reports, and update evaluation case counts.Type of change
.claude/skills/<name>/) — eval fixtures updated belowtools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md)projects/_template/)prek, workflows, validators)Test plan
prek run --all-filespassesuv run pytest/ruff check/mypypasses(
PYTHONPATH=tools/skill-evals/src python3 -m skill_evals.runner tools/skill-evals/evals/<skill>/)(a regression test for the bug fixed / the behaviour added — see CONTRIBUTING.md)
render-preflight-fixtureshook.git diff --checkpassed.RFC-AI-0004 compliance
Linked issues
Closes #1656
Refs #1654
Notes for reviewers (optional)
case-11-issue-first-runfixture uses thetriageskill withsurface_hash: sha256:fb90bdc45aec5f8a.magpie-issue-triageentry from the Security familyissue-triageentry to prevent incorrect family resolution.AI assistance disclosure: AI assistance was used for repository inspection, implementation drafting, and review. Changes were applied and validated locally by the contributor.