Skip to content

Hibernate 7 - Step 1#15654

Open
jdaugherty wants to merge 74 commits into
8.0.xfrom
8.0.x-stage-hibernate7
Open

Hibernate 7 - Step 1#15654
jdaugherty wants to merge 74 commits into
8.0.xfrom
8.0.x-stage-hibernate7

Conversation

@jdaugherty
Copy link
Copy Markdown
Contributor

@jdaugherty jdaugherty commented May 11, 2026

creating this request by cloning the existing hibernate five modules so that we can easily review the hibernate seven changes between hibernate five and seven

Copy all source, test examples, BOMs, and build config from the
hibernate5 namespace to hibernate7 so that the real hibernate7 PR
can be reviewed as a true delta rather than a sea of new files.

Modules added:

  • grails-hibernate7-bom (copy of grails-hibernate5-bom)
  • grails-data-hibernate7-core, spring-orm, grails-plugin, dbmigration, spring-boot, docs
  • grails-test-examples/hibernate7 (12 projects mirroring hibernate5)
  • gradle/hibernate7-test-config.gradle (skipHibernate7Tests flag)

Build infrastructure:

  • publish-root-config.gradle: register hibernate7 modules for publishing
  • SbomPlugin.groovy: add LGPL exemptions for hibernate5 artifacts used by hibernate7 staging modules
  • settings.gradle: include all hibernate7 projects

Copy all source, test examples, BOMs, and build config from the
hibernate5 namespace to hibernate7 so that the real hibernate7 PR
can be reviewed as a true delta rather than a sea of new files.

Modules added:
- grails-hibernate7-bom (copy of grails-hibernate5-bom)
- grails-data-hibernate7-core, spring-orm, grails-plugin, dbmigration, spring-boot, docs
- grails-test-examples/hibernate7 (12 projects mirroring hibernate5)
- gradle/hibernate7-test-config.gradle (skipHibernate7Tests flag)

Build infrastructure:
- publish-root-config.gradle: register hibernate7 modules for publishing
- SbomPlugin.groovy: add LGPL exemptions for hibernate5 artifacts used by hibernate7 staging modules
- settings.gradle: include all hibernate7 projects
@jdaugherty jdaugherty requested a review from jamesfredley May 12, 2026 01:40
@jdaugherty
Copy link
Copy Markdown
Contributor Author

This PR is #1 for the hibernate PR. Basically, I cloned the hibernate5 projects and then created this PR as if they were the hibernate 7 artifacts. This then allows the actual hibernate PR to be meaningful since we can better see what changed. It's not perfect, but it did cut out about 400+ files to review this way.

@jdaugherty
Copy link
Copy Markdown
Contributor Author

I went ahead and renamed hibernate6.gorm.suite to hibernate7.gorm.suite in this initial PR since otherwise the tests will fail that are ignored.

@jdaugherty jdaugherty changed the title stage: clone hibernate5 modules to hibernate7 as baseline Hibernate 7 - Step 1 May 12, 2026
Copy link
Copy Markdown
Contributor

@matrei matrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jdaugherty !

There are some TCK tests that are failing because they only have
@IgnoreIf({ System.getProperty('hibernate5.gorm.suite') })
and not
@IgnoreIf({ System.getProperty('hibernate7.gorm.suite') })

@jdaugherty
Copy link
Copy Markdown
Contributor Author

Per discussion, I've pulled forward the addAllDomainClasses, the common base spec for mongo, & the package renames from tests -> specs

@jdaugherty jdaugherty requested a review from borinquenkid May 12, 2026 14:32
@jdaugherty jdaugherty force-pushed the 8.0.x-stage-hibernate7 branch from 06fe15d to f18465a Compare May 12, 2026 15:20
@matrei
Copy link
Copy Markdown
Contributor

matrei commented May 13, 2026

Should commit 06fe15d be on this branch?

@jdaugherty
Copy link
Copy Markdown
Contributor Author

@matrei i had removed it from this branch since it's to fix the datastore changes in the other branch.

@jdaugherty
Copy link
Copy Markdown
Contributor Author

@matrei Actually, it looks like it got readded somehow, let me try to take it off again

@jdaugherty jdaugherty force-pushed the 8.0.x-stage-hibernate7 branch from 6783934 to 4c5c563 Compare May 13, 2026 18:58
@jdaugherty
Copy link
Copy Markdown
Contributor Author

@matrei I believe I have removed this now.

Comment thread gradle/functional-test-config.gradle Outdated
@jdaugherty jdaugherty force-pushed the 8.0.x-stage-hibernate7 branch from 7d92c56 to 030265f Compare May 17, 2026 13:17
@jdaugherty jdaugherty force-pushed the 8.0.x-stage-hibernate7 branch from 030265f to dfb255f Compare May 17, 2026 13:23
@jdaugherty
Copy link
Copy Markdown
Contributor Author

  • I've added tests to show how to extend the criteria & hibernate criteria builder.
  • I've pulled forward the test lens fix
  • code style is no longer a kitchen sink / it's been split up properly

@jdaugherty
Copy link
Copy Markdown
Contributor Author

@jamesfredley @borinquenkid @matrei assuming the tests all pass, this is ready to review now

@jdaugherty jdaugherty requested review from jamesfredley and matrei May 17, 2026 16:34
@jdaugherty jdaugherty force-pushed the 8.0.x-stage-hibernate7 branch from 26950bc to 263f7ed Compare May 17, 2026 17:08
@testlens-app

This comment has been minimized.

@jamesfredley jamesfredley moved this to In Progress in Apache Grails May 20, 2026
@jamesfredley jamesfredley added this to the grails:8.0.0-M2 milestone May 20, 2026
@jamesfredley
Copy link
Copy Markdown
Contributor

@sbglasius @codeconsole @borinquenkid @matrei I think this step 1 base PR for Hibernate 7.2 is ready to merge, which sets us up to dive deeper into the final reviews of #15568. We need 1 more approver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

3 participants