Commit 06fe15d
fix: SimpleMapQuery distinct projection and GroovyChangeLogSpec CI log capture
- Add DistinctProjection handling in SimpleMapQuery.executeQuery() so
findAllBy* finders return results on the SimpleMap datastore instead
of an empty list. FindAllByFinder.adjustQuery() always adds a distinct
projection; without this handler the projection branch produced no results.
Regression introduced when H7 routed Iterable<T> findBy* through
FindAllByImplementer which generates findAllBy* calls.
- Add regression test 'test find all by finder on simple map datastore'
in ServiceImplSpec to cover findAllByName and findAllByTypeLike on
the SimpleMap datastore.
- Set follow=true on Logback ConsoleAppender in both H5 and H7
dbmigration test logback.groovy. Without this Logback caches the
System.out reference at initialisation time (before Spock's
StandardStreamsCapturer wraps it), so Liquibase log output misses
the @OutputCapture listener. follow=true makes Logback re-resolve
System.out on every write, matching the currently-active capture
stream. This fixes GroovyChangeLogSpec CI failures in the Groovy
Joint Validation Build where the Groovy snapshot changes the
transitive classpath and Liquibase switches to the SLF4J backend.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent f18465a commit 06fe15d
4 files changed
Lines changed: 17 additions & 0 deletions
File tree
- grails-data-hibernate5/dbmigration/src/test/resources
- grails-data-hibernate7/dbmigration/src/test/resources
- grails-data-simple/src/main/groovy/org/grails/datastore/mapping/simple/query
- grails-datamapping-core-test/src/test/groovy/grails/gorm/services
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
23 | 24 | | |
24 | 25 | | |
25 | 26 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
23 | 24 | | |
24 | 25 | | |
25 | 26 | | |
| |||
grails-data-simple/src/main/groovy/org/grails/datastore/mapping/simple/query/SimpleMapQuery.groovy
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
96 | 101 | | |
97 | 102 | | |
98 | 103 | | |
| |||
Lines changed: 10 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
87 | 97 | | |
88 | 98 | | |
89 | 99 | | |
| |||
0 commit comments