Repository navigation
fix: evaluate native Fusion expressions and allow random in Preview/Apply - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Paramood 1.6.0 rejected valid physical/compound expressions and refused random-dependent batches. Delegate original numeric expressions to Fusion and remove those runtime refusals.
All 96 documented units, canonical aliases, affine temperatures, physical/compound dimensions, valid fractional powers, lazy conditionals, implicit unit promotion, dimensioned rounding/sign, and native unit symbols are covered. Sampled previews display ≈ and a short English note. Random dependency markers propagate through snapshots and variants; formulas and deterministic values still guard stale previews.
Evidence
After: 496 Python tests plus 22 subtests, 162 frontend tests, 48 IntelliSense tests, Ruff 0.17.3, Prettier, ESLint, TypeScript/Vite, compilation, ZIP/SHA-256 and stable release contract pass locally.
Merge Danger
Door: two-way
No command IDs, manifest UUID, dependency versions or versioning configuration change. Read-only native evaluation creates no preview parameters; graph/document/formula/type guards remain. Only random-dependent sampled numeric values are excluded from stable-value equality checks. Security review confirms native expression parsing rather than Python eval and retains bridge payload bounds.
Blast Radius: expressions
Native Windows, cloud Save and full add-in restart remain unverified. The previous restart crash is outside this fix. See docs/EXPRESSION_ACCEPTANCE.md for precise offline/native/UI boundaries.