Repository navigation
feat: complete Fusion expression IntelliSense - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The editor previously offered ten functions and the planner rejected many valid Fusion expressions. Share the complete documented catalog across the editor and Python planner, with English metadata and conservative diagnostics.
Adds 26 documented functions, four constants, logical operators, active argument tracking, parenthesis reuse, narrow-palette styling, and incomplete-draft guards. Extends arithmetic, dimensional intermediates, conditionals, and native preference-sensitive evaluation.
random()remains available through native Quick Calculator and explicitly cannot promise stable Preview/Apply.Evidence
After: 379 Python tests plus 22 subtests, 160 frontend tests, and 47 IntelliSense tests pass. Ruff 0.17.3, Prettier, ESLint, TypeScript/Vite, compilation, reproducible ZIP/catalog, SHA-256, and release-contract checks pass locally.
16), and inline constant edit (2 * PI) passed. User documents were preserved.Merge Danger
Door: two-way
Runtime changes can be reverted; the normal automatic release remains immutable. No command IDs, manifest UUID, user documents, or versioning mechanism changed. Security review retained bounded AST evaluation, no dynamic code evaluation, read-only native fallback, and pre-write Fusion checks.
Blast Radius: expressions
Final batch quantities remain length, angle, unitless, or text. Other physical units and fractional dimensions fail explicitly; diagnostics cover only provable local cases. Windows Fusion, light-theme native UI, cloud Save, and full add-in stop/restart were not tested. The existing reported restart crash is not claimed fixed. See
docs/EXPRESSION_ACCEPTANCE.mdanddocs/EXPRESSION_REFERENCE.md.