Refresh shared UI i18n handling#32
Open
52sanmao wants to merge 5 commits into
Open
Conversation
- Add Ui.SetupWizard.Fetch.*, Rebuild.*, Bucket.*, CouchDB.*, P2P.*, CouchDBCheck.* keys to en.yaml - Add Setup.ScanQRCode.*, UseSetupURI.*, RemoteE2EE.*, Bucket.*, CouchDB.*, P2P.* keys to en.yaml - Regenerate all language JSON files from YAML sources - Bake combinedMessages.prod.ts from dev sources - Update Guidance.svelte and Instruction.svelte with message prop auto-translation
- Add all missing $msg() keys referenced by TS settings panes - Add better English values for common labels (Back, Delete, Configure, etc.) - All 841 en.json keys now cover all $msg() calls in codebase
- zh: +93 keys - ja: +96 keys - ko: +133 keys - es: +238 keys - ru: +93 keys - de: +670 keys - zh-tw: +670 keys All 841 keys now present in every language file. Non-translated keys use English as placeholder.
52sanmao
force-pushed
the
i18n-runtime-refresh
branch
from
b91338e to
9e377ff
Compare
Owner
|
Thank you for your PR! |
Owner
|
@52sanmao Sorry for not getting in touch. As I had made a significant diff, I have made some adjustments to align your PR with the Main branch. I am not entirely sure if I have managed to preserve the content of your PR, so would you please check it for me? If it looks OK, I will l merge it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
This is the companion shared UI i18n change for vrtmrz/obsidian-livesync#878.
The parent PR uses shared setup UI components with i18n message keys. Those components also need to remain safe for existing callers that pass literal or dynamic strings.
Purpose
Changed Files
src/UI/components/**translateIfAvailable().src/common/i18n.tssrc/common/messagesYAML/**src/common/messages/**andsrc/common/messagesJson/**Verification
Verified through the parent obsidian-livesync build using this submodule commit:
npm run tsc-checknpm run svelte-checknpm run buildgit diff --checkgit -C src/lib diff --checkCompatibility / Notes