Skip to content

Fix: Add relative_timestamp column to output in Mooncake deserializer#855

Merged
mergify[bot] merged 2 commits into
vllm-project:mainfrom
SkiHatDuckie:hotfix-mooncake
Jun 25, 2026
Merged

Fix: Add relative_timestamp column to output in Mooncake deserializer#855
mergify[bot] merged 2 commits into
vllm-project:mainfrom
SkiHatDuckie:hotfix-mooncake

Conversation

@SkiHatDuckie

@SkiHatDuckie SkiHatDuckie commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Summary

This is a separate PR for the bug fix contained in #829, if we instead wish to just get the bug fix in for v0.7.0. This will be closed if the trace file refactor is merged, or after the release of v0.7.0.

Details

  • Fixed a bug with Mooncake format not working with multiprocessing

Related Issues


  • "I certify that all code in this PR is my own, except as noted below."

Use of AI

  • Includes code generated or substantially modified by an AI agent
  • Includes tests generated or substantially modified by an AI agent

NOTE: the Generated-by or Assisted-by trailers should be used in git commit messages when code or tests were generated or substantially modified by an AI agent, as described in the project's DEVELOPING.md file.


git log

commit 3b89ec2
Author: SkiHatDuckie SkiHatDuckie@gmail.com
Date: Thu Jun 25 11:54:24 2026 -0400

Hotfix: Add relative_timestamp column to output in Mooncake deserializer

Signed-off-by: SkiHatDuckie <SkiHatDuckie@gmail.com>

commit 8d2cba0
Author: SkiHatDuckie SkiHatDuckie@gmail.com
Date: Thu Jun 25 12:59:10 2026 -0400

Move `timestamps` outside the loop

Signed-off-by: SkiHatDuckie <SkiHatDuckie@gmail.com>

Signed-off-by: SkiHatDuckie SkiHatDuckie@gmail.com

Signed-off-by: SkiHatDuckie <SkiHatDuckie@gmail.com>
dbutenhof
dbutenhof previously approved these changes Jun 25, 2026
Comment thread src/guidellm/data/deserializers/trace_mooncake.py Outdated
@mergify

mergify Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Queued — the merge queue status continues in this comment ↓.

Signed-off-by: SkiHatDuckie <SkiHatDuckie@gmail.com>
@mergify

mergify Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • Entered queue2026-06-25 18:11 UTC · Rule: default · triggered by merge protections
  • Checks skipped · PR is already up-to-date
  • Merged2026-06-25 18:11 UTC · at 8d2cba0528b556919f876230d847138d9b271e79 · squash

This pull request spent 15 seconds in the queue, including 1 second running CI.

Required conditions to merge
  • any of [🛡 GitHub repository ruleset rule Merge Requirements]:
    • check-success = quality (3.10) / type-checks
    • check-neutral = quality (3.10) / type-checks
    • check-skipped = quality (3.10) / type-checks
  • any of [🛡 GitHub repository ruleset rule Merge Requirements]:
    • check-success = quality (3.10) / precommit-checks
    • check-neutral = quality (3.10) / precommit-checks
    • check-skipped = quality (3.10) / precommit-checks
  • any of [🛡 GitHub repository ruleset rule Merge Requirements]:
    • check-success = quality (3.10) / quality-checks
    • check-neutral = quality (3.10) / quality-checks
    • check-skipped = quality (3.10) / quality-checks
  • any of [🛡 GitHub repository ruleset rule Merge Requirements]:
    • check-success = tests (3.10) / e2e-tests
    • check-neutral = tests (3.10) / e2e-tests
    • check-skipped = tests (3.10) / e2e-tests
  • any of [🛡 GitHub repository ruleset rule Merge Requirements]:
    • check-success = tests (3.10) / integration-tests
    • check-neutral = tests (3.10) / integration-tests
    • check-skipped = tests (3.10) / integration-tests
  • any of [🛡 GitHub repository ruleset rule Merge Requirements]:
    • check-success = tests (3.10) / unit-tests
    • check-neutral = tests (3.10) / unit-tests
    • check-skipped = tests (3.10) / unit-tests
  • any of [🛡 GitHub repository ruleset rule Merge Requirements]:
    • check-success = update-description
    • check-neutral = update-description
    • check-skipped = update-description

@mergify mergify Bot added the queued label Jun 25, 2026
@mergify mergify Bot merged commit 9dd91cc into vllm-project:main Jun 25, 2026
12 checks passed
@mergify mergify Bot removed the queued label Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants