More refactor cleanup tasks#846
Open
sjmonson wants to merge 5 commits into
Open
Conversation
Assisted-by: GitHub Copilot GPT-4.1 Signed-off-by: Samuel Monson <smonson@redhat.com>
Signed-off-by: Samuel Monson <smonson@redhat.com>
Assisted-by: GitHub Copilot GPT-4.1 Signed-off-by: Samuel Monson <smonson@redhat.com>
Wires the label metadata field to the CLI. Assisted-by: GitHub Copilot GPT-4.1 Signed-off-by: Samuel Monson <smonson@redhat.com>
dbutenhof
previously approved these changes
Jun 25, 2026
dbutenhof
left a comment
Collaborator
There was a problem hiding this comment.
Reluctantly, since it beats blocking the option entirely...
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
Signed-off-by: Samuel Monson <smonson@redhat.com>
dbutenhof
approved these changes
Jun 25, 2026
dbutenhof
left a comment
Collaborator
There was a problem hiding this comment.
OK, so sample_requests = benchmark_args.profile.sample_size is a little weird; but that's all internal so no big deal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handles a bunch of missing pieces from the refactor. See individual commits below.
Test Plan
--labels are applied to output--profile ...,sample_requests=#results in a downsampling of requests in outputguidellm run --helpto ensure that the new help messages exists and are helpful.Related Issues
Use of AI
git log
commit 3ba2d67
Author: Samuel Monson smonson@redhat.com
Date: Tue Jun 23 16:38:37 2026 -0400
commit 0116efc
Author: Samuel Monson smonson@redhat.com
Date: Tue Jun 23 16:43:05 2026 -0400
commit 20a1dcd
Author: Samuel Monson smonson@redhat.com
Date: Wed Jun 24 14:20:06 2026 -0400
commit 882fb54
Author: Samuel Monson smonson@redhat.com
Date: Wed Jun 24 15:18:41 2026 -0400
commit 56b612f
Author: Samuel Monson smonson@redhat.com
Date: Thu Jun 25 14:49:12 2026 -0400
Assisted-by: GitHub Copilot GPT-4.1
Signed-off-by: Samuel Monson smonson@redhat.com