Skip to content

More refactor cleanup tasks#846

Open
sjmonson wants to merge 5 commits into
vllm-project:mainfrom
sjmonson:refactor/schema/cleanup_2
Open

More refactor cleanup tasks#846
sjmonson wants to merge 5 commits into
vllm-project:mainfrom
sjmonson:refactor/schema/cleanup_2

Conversation

@sjmonson

@sjmonson sjmonson commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

Handles a bunch of missing pieces from the refactor. See individual commits below.

Test Plan

  • Check that --labels are applied to output
  • Verify --profile ...,sample_requests=# results in a downsampling of requests in output
  • Check guidellm run --help to ensure that the new help messages exists and are helpful.

Related Issues


  • "I certify that all code in this PR is my own, except as noted below."

Use of AI

  • Includes code generated or substantially modified by an AI agent
  • Includes tests generated or substantially modified by an AI agent

NOTE: the Generated-by or Assisted-by trailers should be used in git commit messages when code or tests were generated or substantially modified by an AI agent, as described in the project's DEVELOPING.md file.


git log

commit 3ba2d67
Author: Samuel Monson smonson@redhat.com
Date: Tue Jun 23 16:38:37 2026 -0400

Move sample_requests to profile

Assisted-by: GitHub Copilot GPT-4.1
Signed-off-by: Samuel Monson <smonson@redhat.com>

commit 0116efc
Author: Samuel Monson smonson@redhat.com
Date: Tue Jun 23 16:43:05 2026 -0400

Move prefer_response_metrics back to settings

Signed-off-by: Samuel Monson <smonson@redhat.com>

commit 20a1dcd
Author: Samuel Monson smonson@redhat.com
Date: Wed Jun 24 14:20:06 2026 -0400

Add help message to --override

Assisted-by: GitHub Copilot GPT-4.1
Signed-off-by: Samuel Monson <smonson@redhat.com>

commit 882fb54
Author: Samuel Monson smonson@redhat.com
Date: Wed Jun 24 15:18:41 2026 -0400

Add label CLI option

Wires the label metadata field to the CLI.

Assisted-by: GitHub Copilot GPT-4.1
Signed-off-by: Samuel Monson <smonson@redhat.com>

commit 56b612f
Author: Samuel Monson smonson@redhat.com
Date: Thu Jun 25 14:49:12 2026 -0400

Rename request_samples to sample_size

Signed-off-by: Samuel Monson <smonson@redhat.com>

Assisted-by: GitHub Copilot GPT-4.1
Signed-off-by: Samuel Monson smonson@redhat.com

sjmonson added 4 commits June 23, 2026 16:38
Assisted-by: GitHub Copilot GPT-4.1
Signed-off-by: Samuel Monson <smonson@redhat.com>
Signed-off-by: Samuel Monson <smonson@redhat.com>
Assisted-by: GitHub Copilot GPT-4.1
Signed-off-by: Samuel Monson <smonson@redhat.com>
Wires the label metadata field to the CLI.

Assisted-by: GitHub Copilot GPT-4.1
Signed-off-by: Samuel Monson <smonson@redhat.com>
@sjmonson sjmonson marked this pull request as ready for review June 25, 2026 17:54
dbutenhof
dbutenhof previously approved these changes Jun 25, 2026

@dbutenhof dbutenhof left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reluctantly, since it beats blocking the option entirely...

@mergify

mergify Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Signed-off-by: Samuel Monson <smonson@redhat.com>

@dbutenhof dbutenhof left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so sample_requests = benchmark_args.profile.sample_size is a little weird; but that's all internal so no big deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants