Skip to content

TST: use double precision for spline round-trip tests - #15

Merged
mj-will merged 1 commit into
glasflowfrom
fix/spline-round-trip-precision
Nov 17, 2026
Merged

mj-will merged 1 commit into
glasflowfrom
fix/spline-round-trip-precision

Conversation

@mj-will

@mj-will mj-will commented Nov 17, 2026 •

Copy link
Copy Markdown

Random float32 cubic-spline inversions intermittently exceed the existing round-trip tolerance, causing the downstream glasflow CI to fail across Linux, Windows, and macOS.

Run the constrained CDF and unconstrained coupling round-trip checks in float64, keeping the existing tolerances. Construct the expected zero log determinant using the input dtype and device. Other forward and inverse tests retain float32 coverage.

@mj-will mj-will changed the title Use double precision for spline round-trip tests TST: use double precision for spline round-trip tests Nov 17, 2026
@mj-will mj-will added the tests Improvements or additions to the test suite label Nov 17, 2026
@mj-will
mj-will merged commit 0d30958 into glasflow Nov 17, 2026
12 checks passed
@mj-will
mj-will deleted the fix/spline-round-trip-precision branch November 17, 2026 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Improvements or additions to the test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant