Repository navigation
TST: use double precision for CDF endpoint checks - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
TestPiecewiseCDF.test_ones_to_onescheck intermittently fails forPiecewiseCubicCDFbecause float32 evaluation at the upper endpoint can exceed the existing1e-5tolerance. This caused the Python 3.12 Ubuntu failure in uofgravity/glasflow#71.Evaluate this endpoint check in float64, following the approach used for the round-trip checks in #15. Keep the existing tolerance and production implementation unchanged.