Skip to content

Add solver repro for fixed GND label trace overlap - #1197

Open
rushabhcodes wants to merge 2 commits into
tscircuit:mainfrom
rushabhcodes:repro-fixed-gnd-label-trace-overlap
Open

rushabhcodes wants to merge 2 commits into
tscircuit:mainfrom
rushabhcodes:repro-fixed-gnd-label-trace-overlap

Conversation

@rushabhcodes

@rushabhcodes rushabhcodes commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Move the fixed-GND-label overlap reproduction from tscircuit/core#3919 into schematic-trace-solver so the captured routing input and output can be investigated directly.

The case comes from SparkFun's VEML7700 board, reduced in core to a chip, capacitor, LED, and manually positioned GND label. The ground wire crosses the fixed label near the chip. The expected end-to-end behavior is to preserve the label position and route other wire segments clear of its bounds.

The fixture captures solver:started input from core PR #3919 at deb549e8. Only symbol names and net label display text are added for readability; routing geometry is unchanged. Like neighboring repros, the test runs SchematicTracePipelineSolver and uses toMatchSolverSnapshot for the standard solver debug and schematic views. A geometry assertion records the current ground route crossing the original fixed label's bounds.

Core omits the explicitly positioned label from the captured solver input, so that label is absent from the solver snapshot. The test does not inject it into the rendered output. This reproduces an integration failure; it does not establish that the solver ignored a supplied obstacle. A fix needs to address how fixed-label geometry is supplied and preserved. This PR contains no routing implementation changes.

Validation:

  • bun test tests/repros/repro-fixed-gnd-label-trace-overlap.test.ts passes against the regenerated snapshot without updating it.
  • bunx tsc --noEmit passes.
  • Visually inspected the shared debug/schematic snapshot.
  • Formatting and whitespace checks pass.

Copilot AI lite review requested due to automatic review settings September 12, 2026 20:39
@vercel

vercel Bot commented Sep 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
schematic-trace-solver Ready Ready Preview Sep 12, 2026 8:52pm UTC

Request Review

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

This branch was successfully deployed

1 active deployment
Preview da7cdc3d Deployed Sep 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants