Add solver repro for fixed GND label trace overlap - #1197
Open
rushabhcodes wants to merge 2 commits into
Open
rushabhcodes wants to merge 2 commits into
rushabhcodes wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the fixed-GND-label overlap reproduction from tscircuit/core#3919 into schematic-trace-solver so the captured routing input and output can be investigated directly.
The case comes from SparkFun's VEML7700 board, reduced in core to a chip, capacitor, LED, and manually positioned GND label. The ground wire crosses the fixed label near the chip. The expected end-to-end behavior is to preserve the label position and route other wire segments clear of its bounds.
The fixture captures
solver:startedinput from core PR #3919 atdeb549e8. Only symbol names and net label display text are added for readability; routing geometry is unchanged. Like neighboring repros, the test runsSchematicTracePipelineSolverand usestoMatchSolverSnapshotfor the standard solver debug and schematic views. A geometry assertion records the current ground route crossing the original fixed label's bounds.Core omits the explicitly positioned label from the captured solver input, so that label is absent from the solver snapshot. The test does not inject it into the rendered output. This reproduces an integration failure; it does not establish that the solver ignored a supplied obstacle. A fix needs to address how fixed-label geometry is supplied and preserved. This PR contains no routing implementation changes.
Validation:
bun test tests/repros/repro-fixed-gnd-label-trace-overlap.test.tspasses against the regenerated snapshot without updating it.bunx tsc --noEmitpasses.