Skip to content

Add repro for routed trace overlapping fixed GND label - #3919

Closed
rushabhcodes wants to merge 1 commit into
tscircuit:mainfrom
rushabhcodes:repro-fixed-gnd-label-trace-overlap
Closed

rushabhcodes wants to merge 1 commit into
tscircuit:mainfrom
rushabhcodes:repro-fixed-gnd-label-trace-overlap

Conversation

@rushabhcodes

Copy link
Copy Markdown
Contributor

A manually positioned GND label in the SparkFun VEML7700 schematic is crossed by an automatically routed wire on the same net. The fixed symbol connects to U1.pin3, while the separate U1-to-D1 ground route passes through the GND text. The expected behavior is to preserve the chosen label position and route around its symbol/text bounds.

Add a minimal reproduction containing one generic chip, one capacitor, one LED, and the fixed GND label, plus a schematic SVG snapshot. The fixture removes the original board's connectors, pull-ups, jumper circuitry, footprints, and external assets. PCB rendering is disabled, and the portrait snapshot keeps the entire ground route visible.

This PR records the current faulty output for investigation; it does not change routing behavior. In the generated Circuit JSON, the routed vertical segment is at x = -1.17, only 0.07 mm from the fixed label's x = -1.1 anchor, and crosses its text area. Core currently excludes explicitly positioned labels from automatic label placement, while the solver input's text obstacles are collected from component-associated schematic_text rather than these schematic_net_label records.

Reproduction:

bun test tests/repros/repro-fixed-gnd-label-trace-overlap.test.tsx

Validation:

  • Based on freshly fetched upstream main at eacf4d0 (core 0.0.1902).
  • Generated and visually inspected the schematic snapshot, confirming the GND text overlap.
  • Re-ran the repro test successfully without updating snapshots.
  • Biome check and git diff whitespace check pass.

Copilot AI lite review requested due to automatic review settings September 12, 2026 19:52
@vercel

vercel Bot commented Sep 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
tscircuit-core-benchmarks Ready Ready Preview Sep 12, 2026 7:52pm UTC

Request Review

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@rushabhcodes

Copy link
Copy Markdown
Contributor Author

Moved the reproduction to tscircuit/schematic-trace-solver#1197. The replacement includes captured solver input, a standalone test, and a schematic snapshot. It explicitly documents that the fixed GND label is absent from the captured solver input and is rendered as context for the overlap.

This branch was successfully deployed

1 active deployment
Preview deb549e8 Deployed Sep 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants