Add repro for routed trace overlapping fixed GND label - #3919
Closed
rushabhcodes wants to merge 1 commit into
Closed
rushabhcodes wants to merge 1 commit into
rushabhcodes wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
Moved the reproduction to tscircuit/schematic-trace-solver#1197. The replacement includes captured solver input, a standalone test, and a schematic snapshot. It explicitly documents that the fixed GND label is absent from the captured solver input and is rendered as context for the overlap. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A manually positioned GND label in the SparkFun VEML7700 schematic is crossed by an automatically routed wire on the same net. The fixed symbol connects to U1.pin3, while the separate U1-to-D1 ground route passes through the GND text. The expected behavior is to preserve the chosen label position and route around its symbol/text bounds.
Add a minimal reproduction containing one generic chip, one capacitor, one LED, and the fixed GND label, plus a schematic SVG snapshot. The fixture removes the original board's connectors, pull-ups, jumper circuitry, footprints, and external assets. PCB rendering is disabled, and the portrait snapshot keeps the entire ground route visible.
This PR records the current faulty output for investigation; it does not change routing behavior. In the generated Circuit JSON, the routed vertical segment is at x = -1.17, only 0.07 mm from the fixed label's x = -1.1 anchor, and crosses its text area. Core currently excludes explicitly positioned labels from automatic label placement, while the solver input's text obstacles are collected from component-associated schematic_text rather than these schematic_net_label records.
Reproduction:
bun test tests/repros/repro-fixed-gnd-label-trace-overlap.test.tsxValidation: