Support PCB dimension offset directions - #886
Merged
ShiboSoftwareDev merged 2 commits intoOct 1, 2026
Merged
Conversation
This was referenced Oct 1, 2026
ShiboSoftwareDev
changed the title
This was referenced Oct 1, 2026
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PCB and fabrication dimensions need both an offset magnitude and a direction to preserve imported board annotations. Add optional unitless
offsetDirectionin footprint-local coordinates to both primitive prop schemas while retaining the existing unit-awareoffsetdistance. Omission keeps the existing API; runtime support uses the perpendicular to the endpoints when no direction is supplied.Found while addressing tscircuit/circuit-json-to-tscircuit#130 and #132.
Validation: focused schema regressions pass, TypeScript typecheck and format checks pass. All four required documentation/type generation scripts were run and their outputs included.
Runtime implementation: tscircuit/core#4266.