Preserve PCB dimension offset vectors - #4266
Merged
ShiboSoftwareDev merged 5 commits intoOct 1, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Oct 1, 2026
ShiboSoftwareDev
changed the title
This was referenced Oct 1, 2026
ShiboSoftwareDev
force-pushed
the
fix/fabrication-dimension-offset
branch
from
October 1, 2026 19:08
768bd5e to
68b5672
Compare
ShiboSoftwareDev
force-pushed
the
fix/fabrication-dimension-offset
branch
from
October 1, 2026 19:15
68b5672 to
c43ab28
Compare
ShiboSoftwareDev
marked this pull request as ready for review
October 1, 2026 19:23
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PCB note and fabrication note dimensions must emit native
offset_distanceplusoffset_direction; pre-shifting endpoints or authoring extra extension paths duplicates renderer geometry. Explicit footprint-local directions rotate/reflect with the PCB transform without receiving translation. Scalar-only offsets use the perpendicular to board-space endpoints, and coincident endpoints avoid division by zero.Adds emitted-geometry assertions and visual regressions, including a short 0.25 mm oblique PCB-note offset that exposes duplicate extension lines. Existing fabrication transform coverage remains intact.
Uses released
@tscircuit/props@0.0.674from tscircuit/props#886. The temporary development patch has been removed.The printed-coil repro snapshot was regenerated because it contains a scalar-offset fabrication dimension: the dimension now renders at its authored offset instead of directly on the measured line.
Validation: focused PCB/fabrication dimension regressions (49 assertions), the printed-coil repro, TypeScript typecheck, and format checks pass against the published props package.
Converter mappings: tscircuit/circuit-json-to-tscircuit#130 and tscircuit/circuit-json-to-tscircuit#132.