Repository navigation
Conversation
This was referenced Oct 1, 2026
imrishabh18
requested changes
Oct 1, 2026
imrishabh18
left a comment
imrishabh18
left a comment
Member
There was a problem hiding this comment.
Start with a reproduction test PR in core before these changes
seveibar
approved these changes
Oct 2, 2026
seveibar
requested changes
Oct 2, 2026
seveibar
left a comment
seveibar
left a comment
Contributor
There was a problem hiding this comment.
not sure what this is needed for
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
|
This PR was closed because it has been inactive for 1 day since being marked as stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Silkscreen rectangle props currently strip
pcbRotation, so a converted rectangle loses its orientation. Preserve the common unit-aware rotation prop, including arbitrary and negative angles, without swapping its dimensions.Found while auditing tscircuit/circuit-json-to-tscircuit#89.
Validation: all 574 tests pass, TypeScript typecheck and package build pass. All four required documentation/type generation scripts were run and their outputs included.
Runtime implementation: tscircuit/core#4265. Converter mapping: tscircuit/circuit-json-to-tscircuit#119.