Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Oct 1, 2026
Draft
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
|
This PR was closed because it has been inactive for 1 day since being marked as stale. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Silkscreen rectangles currently discard arbitrary rotation and swap dimensions for quarter turns. Preserve their local width/height and emit the orientation of the transformed +X direction as
ccw_rotation, including reflected bottom-layer footprints. Compute the axis-aligned PCB size from transformed corners and preserve rotation when importing Circuit JSON footprints.A labelled visual regression covers parent rotations 0/90/180/270/30 degrees on both layers with an additional 15-degree rectangle rotation. A pad on the rectangle's local +X edge independently checks emitted geometry. Found while auditing tscircuit/circuit-json-to-tscircuit#89.
Depends on tscircuit/props#884. A narrow development-only Bun patch mirrors that props change. This PR stays draft until the props release is available; replace the patch with that release before merging.
Validation: all 15 related silkscreen tests pass, including the existing rotation repro; the package ESM/declaration build and the new regression's TypeScript check pass.
Converter mapping: tscircuit/circuit-json-to-tscircuit#119.