Repository navigation
Conversation
What was broken The opportunities challenge sidebar listed the manual review in Review Style only as "Manual". Members could not open the scorecard the manual review uses. The design asks for "Manual: Scorecard Link". Root cause The sidebar only knew the AI review config mode. It never read the challenge review definition (challenge.reviewers), which holds the member reviewer's scorecardId. The opportunities models did not type those reviewer fields or the phase type id the reviewers point to. What was changed - Added challengeManualReviewScorecardId and challengeManualReviewScorecardUrl to challenge-detail.utils. They pick the member (non-AI) reviewer on the Review phase, falling back to Iterative Review, and build the public Review App scorecard URL (REVIEW_APP_URL/scorecard/<id>). - ChallengeSidebar passes that URL to ReviewStyleSection. The Manual bullet now reads "Manual: Scorecard Link" with the existing tooltip. The link is only added when no AI review config exists. - Typed ChallengeReviewer isMemberReview/phaseId/scorecardId and ChallengePhase phaseId. Added/updated tests - challenge-detail.utils.spec.ts covers Review phase selection, the Iterative Review fallback, id encoding, and ignoring AI and screening reviewers. - ChallengeSidebar.spec.tsx covers the Manual scorecard link and checks that AI review modes do not get the link. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PM-6648
What's in this PR?
What was broken
The opportunities challenge sidebar listed the manual review in Review Style only as
Manual. Members could not open the scorecard the manual review uses. The design asks for• Manual: Scorecard Link ⓘ.Root cause
The sidebar only knew the AI review config mode. It never read the challenge review definition (
challenge.reviewers), which holds the member reviewer'sscorecardId. The opportunities models did not type those reviewer fields or the phase type id (phase.phaseId) the reviewers point to.What was changed
utils/challenge-detail.utils.ts: newchallengeManualReviewScorecardIdandchallengeManualReviewScorecardUrl.isMemberReview, non-AI) reviewer on the Review phase, falling back to Iterative Review. Screening, approval and AI workflow reviewers are ignored.REVIEW_APP_URL/scorecard/<id>). Admin tooling and the work app already link to this URL.components/ChallengeSidebar.tsx:ReviewStyleSectionreceives that URL. The Manual bullet now readsManual: Scorecard Link(opens in a new tab) with the existing tooltip. The link is only added when no AI review config exists; AI Gating and AI only are unchanged.models/opportunity.models.ts: typedChallengeReviewer.isMemberReview/phaseId/scorecardIdandChallengePhase.phaseId.The matching legacy community-app change is topcoder-platform/community-app#7292.
Added/updated tests
challenge-detail.utils.spec.ts: Review phase selection, Iterative Review fallback, id encoding, ignoring AI and screening reviewers.ChallengeSidebar.spec.tsx: the Manual scorecard link, and no link for AI review modes.Validation
CI=true yarn -s craco test --watchAll=false src/apps/opportunities: 65 suites and 821 tests passedyarn lint: passnpx tsc --noEmit -p tsconfig.json: passyarn run build: passChallengeSidebarfrom a dev challenge payload (60f35fb5-…). It showsManual: Scorecard Link→https://review.topcoder-dev.com/scorecard/hFU73Ve2XlYCK-, matching the design. That page andGET /v6/scorecards/:idare both public.🤖 Generated with Claude Code