Skip to content

PM-6648: Link manual review scorecard in challenge sidebar - #7292

Merged
jmgasper merged 1 commit into
developfrom
PM-6648
Oct 22, 2026
Merged

jmgasper merged 1 commit into
developfrom
PM-6648

Conversation

@jmgasper

@jmgasper jmgasper commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

Jira: PM-6648

What was broken

The challenge details sidebar showed the final review only as "Community Review Board". Members could not see which scorecard the manual review uses. The design asks for "Final Review → Manual: Scorecard Link ⓘ".

Root cause

The sidebar only read the legacy phase Scorecard constraint. None of the 30 active dev challenges checked set that constraint. The sidebar never used the challenge review definition (challenge.reviewers), which holds the member reviewer's scorecardId.

What was changed

  • New src/shared/utils/challenge-detail/manual-review-scorecard.js:
    • Picks the member (isMemberReview, non-AI) reviewer on the Review phase, falling back to Iterative Review. Screening, approval and AI workflow reviewers are ignored.
    • Builds the public Review App scorecard URL (config.REVIEW_APP_URL/scorecard/<id>).
  • Specification passes that URL to SideBar.
  • The SideBar "Final Review" line now shows Manual: Scorecard Link (opens in a new tab) with the existing tooltip. Without a manual review scorecard it still shows the previous label.

The matching platform-ui (new community app) change is topcoder-platform/platform-ui#2547.

Added/updated tests

  • __tests__/shared/utils/challenge-detail/manual-review-scorecard.test.js: Review phase selection, Iterative Review fallback, ignoring AI and screening reviewers, URL building.
  • __tests__/shared/components/challenge-detail/Specification/SideBar.jsx: the scorecard link and the fallback label.

Validation

  • npm run lint: pass
  • npm run build: pass
  • npm run jest: 177 suites and 502 tests passed (4 suites and 23 tests skipped, as on develop)
  • Rendered the SideBar from a real dev challenge payload (60f35fb5-…). It shows Manual: Scorecard Link → https://review.topcoder-dev.com/scorecard/hFU73Ve2XlYCK-. That page and GET /v6/scorecards/:id are both public.

🤖 Generated with Claude Code

What was broken
The challenge details sidebar showed the final review only as
"Community Review Board". Members could not see which scorecard the
manual review uses. The design asks for "Manual: Scorecard Link".

Root cause
The sidebar only read the legacy phase "Scorecard" constraint, which v6
challenges no longer set. It never used the challenge review definition
(challenge.reviewers), which holds the member reviewer's scorecardId.

What was changed
- Added utils/challenge-detail/manual-review-scorecard.js. It picks the
  member (non-AI) reviewer on the Review phase, falling back to Iterative
  Review, and builds the public Review App URL
  (REVIEW_APP_URL/scorecard/<id>).
- The Specification view passes that URL to the SideBar.
- The SideBar "Final Review" line now shows "Manual: Scorecard Link" with
  the existing tooltip. Without a manual review scorecard it still shows
  the previous review board label.

Added/updated tests
- __tests__/shared/utils/challenge-detail/manual-review-scorecard.test.js
  covers Review phase selection, the Iterative Review fallback, ignoring
  AI and screening reviewers, and URL building.
- __tests__/shared/components/challenge-detail/Specification/SideBar.jsx
  covers the scorecard link and the fallback label.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jmgasper
jmgasper requested a review from kkartunov as a code owner October 22, 2026 01:12
@jmgasper
jmgasper merged commit 930bacd into develop Oct 22, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant