Repository navigation
Conversation
What was broken The challenge details sidebar showed the final review only as "Community Review Board". Members could not see which scorecard the manual review uses. The design asks for "Manual: Scorecard Link". Root cause The sidebar only read the legacy phase "Scorecard" constraint, which v6 challenges no longer set. It never used the challenge review definition (challenge.reviewers), which holds the member reviewer's scorecardId. What was changed - Added utils/challenge-detail/manual-review-scorecard.js. It picks the member (non-AI) reviewer on the Review phase, falling back to Iterative Review, and builds the public Review App URL (REVIEW_APP_URL/scorecard/<id>). - The Specification view passes that URL to the SideBar. - The SideBar "Final Review" line now shows "Manual: Scorecard Link" with the existing tooltip. Without a manual review scorecard it still shows the previous review board label. Added/updated tests - __tests__/shared/utils/challenge-detail/manual-review-scorecard.test.js covers Review phase selection, the Iterative Review fallback, ignoring AI and screening reviewers, and URL building. - __tests__/shared/components/challenge-detail/Specification/SideBar.jsx covers the scorecard link and the fallback label. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: PM-6648
What was broken
The challenge details sidebar showed the final review only as "Community Review Board". Members could not see which scorecard the manual review uses. The design asks for "Final Review → Manual: Scorecard Link ⓘ".
Root cause
The sidebar only read the legacy phase
Scorecardconstraint. None of the 30 active dev challenges checked set that constraint. The sidebar never used the challenge review definition (challenge.reviewers), which holds the member reviewer'sscorecardId.What was changed
src/shared/utils/challenge-detail/manual-review-scorecard.js:isMemberReview, non-AI) reviewer on the Review phase, falling back to Iterative Review. Screening, approval and AI workflow reviewers are ignored.config.REVIEW_APP_URL/scorecard/<id>).Specificationpasses that URL toSideBar.SideBar"Final Review" line now showsManual: Scorecard Link(opens in a new tab) with the existing tooltip. Without a manual review scorecard it still shows the previous label.The matching platform-ui (new community app) change is topcoder-platform/platform-ui#2547.
Added/updated tests
__tests__/shared/utils/challenge-detail/manual-review-scorecard.test.js: Review phase selection, Iterative Review fallback, ignoring AI and screening reviewers, URL building.__tests__/shared/components/challenge-detail/Specification/SideBar.jsx: the scorecard link and the fallback label.Validation
npm run lint: passnpm run build: passnpm run jest: 177 suites and 502 tests passed (4 suites and 23 tests skipped, as on develop)60f35fb5-…). It showsManual: Scorecard Link→https://review.topcoder-dev.com/scorecard/hFU73Ve2XlYCK-. That page andGET /v6/scorecards/:idare both public.🤖 Generated with Claude Code