Repository navigation
fix: test pg13-18 in CI for old version compat - #1401
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM, straightforward CI/infra config change.
What was reviewed: the docker-compose image tags for tenant_db/multitenant_db now use a ${POSTGRES_VERSION:-15} substitution instead of hardcoded tags, defaulting to 15 for unaffected consumers; the new POSTGRES_VERSION: "13" env blocks in ci.yml (workflow-level) and acceptance.yml (job-level) correctly override the default so CI/acceptance test against pg13. No code logic, auth, or data-handling paths are touched.
Extended reasoning...
Overview
The PR touches only three CI/infra files: .docker/docker-compose-infra.yml, .github/workflows/acceptance.yml, and .github/workflows/ci.yml. It replaces hardcoded Postgres image tags (pg15/15) with a ${POSTGRES_VERSION:-15} shell-style variable substitution (default 15), and adds POSTGRES_VERSION: "13" env vars at the workflow level in ci.yml and job level in acceptance.yml, so CI now exercises Postgres 13 while other consumers of the compose file keep the prior default of 15.
Security risks
None. This is a version-pinning change for a test/dev database image; no secrets, auth, or permission logic is touched, and the env var substitution syntax used (${VAR:-default}) is standard docker-compose behavior, not a shell-injection vector since it's resolved by docker compose itself from a controlled, non-user-supplied environment variable.
Level of scrutiny
Low. This is a small, mechanical, well-scoped config change consistent with the stated goal (testing pg13+ compatibility) and matches the PR description. The diff is easy to verify by inspection — three small hunks, correct YAML placement (env block correctly placed between permissions and concurrency in ci.yml, and at job level in acceptance.yml), and no other workflow references were left inconsistent.
Other factors
No CODEOWNERS restriction applies (none of the changed files matched an owned path in this repo, and none was found). No open review threads or CHANGES_REQUESTED states in the timeline. The bug hunter found no issues, consistent with the change's simplicity.
Coverage Report for CI Build 35142878596Coverage increased (+0.09%) to 82.844%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Signed-off-by: Ferhat Elmas <elmas.ferhat@gmail.com>
cd806fe to
bf92a11
Compare
ferhatelmas
changed the title
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
PG15 is used in CI but we aim pg13+ compatibility.
What is the new behavior?
Use pg13 in CI by default to ensure that old version is compatible.
Run integration tests with from 13 to 18.
Additional context
Related to #1400