Repository navigation
chore: send coverage for one pg version - #1430
Conversation
Signed-off-by: Ferhat Elmas <elmas.ferhat@gmail.com>
There was a problem hiding this comment.
Looks good, straightforward CI config change. Verified the ternary expression syntax for selecting the npm script is valid GitHub Actions expression syntax, and that the new test:integration:ci script mirrors the existing test:coverage:ci pattern (restart infra, seed dummy data, run tests) using scripts that already exist in package.json.
Extended reasoning...
The change only touches .github/workflows/ci.yml and package.json: it conditionally selects test:coverage:ci vs the new test:integration:ci npm script based on matrix.postgres, and gates the Coveralls upload step to only run once (pg 18) instead of once per matrix entry. No security-sensitive surface (no secrets handling changes, no auth/crypto). Confirmed all referenced npm scripts (infra:restart:ci, test:dummy-data, test:integration, test:integration:coverage) already exist, so the new composition is well-formed; the change is small, mechanical, and consistent with existing patterns.
Coverage Report for CI Build 35734884098Coverage decreased (-0.004%) to 83.392%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
What kind of change does this PR introduce?
chore
What is the current behavior?
We started sending multiple integration test coverage after running tests with different pg versions.
What is the new behavior?
Send it once, keep it to pg18.
Additional context
Related to #1401