Skip to content

chore: send coverage for one pg version - #1430

Merged
ferhatelmas merged 1 commit into
masterfrom
ferhat/coverage-pg
Sep 22, 2026
Merged

ferhatelmas merged 1 commit into
masterfrom
ferhat/coverage-pg

Conversation

@ferhatelmas

Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

chore

What is the current behavior?

We started sending multiple integration test coverage after running tests with different pg versions.

What is the new behavior?

Send it once, keep it to pg18.

Additional context

Related to #1401

Signed-off-by: Ferhat Elmas <elmas.ferhat@gmail.com>
Copilot AI lite review requested due to automatic review settings September 22, 2026 13:39
@ferhatelmas
ferhatelmas requested a review from a team as a code owner September 22, 2026 13:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, straightforward CI config change. Verified the ternary expression syntax for selecting the npm script is valid GitHub Actions expression syntax, and that the new test:integration:ci script mirrors the existing test:coverage:ci pattern (restart infra, seed dummy data, run tests) using scripts that already exist in package.json.

Extended reasoning...

The change only touches .github/workflows/ci.yml and package.json: it conditionally selects test:coverage:ci vs the new test:integration:ci npm script based on matrix.postgres, and gates the Coveralls upload step to only run once (pg 18) instead of once per matrix entry. No security-sensitive surface (no secrets handling changes, no auth/crypto). Confirmed all referenced npm scripts (infra:restart:ci, test:dummy-data, test:integration, test:integration:coverage) already exist, so the new composition is well-formed; the change is small, mechanical, and consistent with existing patterns.

@ferhatelmas
ferhatelmas merged commit 74ad989 into master Sep 22, 2026
35 checks passed
@ferhatelmas
ferhatelmas deleted the ferhat/coverage-pg branch September 22, 2026 13:47
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 35734884098

Coverage decreased (-0.004%) to 83.392%

Details

  • Coverage decreased (-0.004%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 14201
Covered Lines: 12270
Line Coverage: 86.4%
Relevant Branches: 8697
Covered Branches: 6825
Branch Coverage: 78.48%
Branches in Coverage %: Yes
Coverage Strength: 765.93 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants